Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DM allocator to use all available names #1626

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Update DM allocator to use all available names #1626

merged 1 commit into from
Jun 19, 2023

Conversation

ConnorJC3
Copy link
Contributor

@ConnorJC3 ConnorJC3 commented Jun 14, 2023 •
edited
Loading

Is this a bug fix or adding new feature?

Bug fix

What is this PR about? / Why do we need it?

Changes the device name allocator to use a list of all legal EBS device names.

Supersedes #1622

What testing is done?

Updated unit tests, manually tested, CI

@ConnorJC3 ConnorJC3 requested review from torredil and hanyuel June 14, 2023 14:15
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 14, 2023
@k8s-ci-robot k8s-ci-robot requested a review from gtxu June 14, 2023 14:15
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 14, 2023
@ConnorJC3
Copy link
Contributor Author

/retest

@hanyuel
Copy link
Contributor

hanyuel commented Jun 14, 2023

Can you please add in your PR description explaining what is the bug/problem?

@torredil
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2023
hanyuel
hanyuel reviewed Jun 15, 2023
View reviewed changes
pkg/cloud/devicemanager/allocator.go
// It does this by using a list of legal EBS device names from device_names.go
func (d *nameAllocator) GetNext(existingNames ExistingNames) (string, error) {
for _, name := range deviceNames {
if _, found := existingNames[name]; !found {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this PR doesn't change it, but why does ExistingNames need to be a map? We care about only the keys, not the values.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ExistingNames is a map because that is how it is stored and passed in manager.go.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2023
@hanyuel
Copy link
Contributor

hanyuel commented Jun 16, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2023
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 16, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2023
@hanyuel
Copy link
Contributor

hanyuel commented Jun 16, 2023

/lgtm

@ConnorJC3
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@ConnorJC3: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-ebs-csi-driver-test-e2e-external-eks-windows e8de6e1 link false /test pull-aws-ebs-csi-driver-test-e2e-external-eks-windows

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ConnorJC3
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit ec2f6fd into kubernetes-sigs:master Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanyuel hanyuel hanyuel left review comments

@torredil torredil torredil approved these changes

@gtxu gtxu Awaiting requested review from gtxu

Assignees

@torredil torredil

@hanyuel hanyuel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ConnorJC3 @hanyuel @torredil @k8s-ci-robot