Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependencies for release v1.24.0 #1781

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Upgrade dependencies for release v1.24.0 #1781

merged 1 commit into from
Oct 13, 2023

Conversation

AndrewSirenko
Copy link
Contributor

Is this a bug fix or adding new feature?

What is this PR about? / Why do we need it?
Upgrade dependencies for release v1.24.0

* go.mod
* go.sum
* hack/e2e/run.sh
*  charts/aws-ebs-csi-driver/values.yaml
* deploy/kubernetes/base/controller.yaml 
* deploy/kubernetes/base/node.yaml
* deploy/kubernetes/overlays/stable/gcr/kustomization.yaml

No changes to
* /pkg/cloud/mock_ec2.go
* /charts/aws-ebs-csi-driver/templates/tests/helm-tester.yaml

What testing is done?
make test, make verify

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 12, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 12, 2023
torredil
torredil approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AndrewSirenko /lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2023
@ConnorJC3
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2023
@torredil
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4f44b36 into kubernetes-sigs:master Oct 13, 2023
@AndrewSirenko AndrewSirenko deleted the dependency124 branch November 1, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torredil torredil torredil approved these changes

@ConnorJC3 ConnorJC3 Awaiting requested review from ConnorJC3

Assignees

@ConnorJC3 ConnorJC3

@torredil torredil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndrewSirenko @ConnorJC3 @torredil @k8s-ci-robot