-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Greatly clarify misleading metadata logging #2049
Greatly clarify misleading metadata logging #2049
Conversation
6c2272e
to
a18de96
Compare
Code Coverage Diff
|
a18de96
to
dca2ff7
Compare
Signed-off-by: Connor Catlett <[email protected]>
dca2ff7
to
643be5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Is this a bug fix or adding new feature?
Bug fix
What is this PR about? / Why do we need it?
The current logging for metadata is extremely misleading and (in some cases) straight up wrong. This PR fixes that (and a few other related issues) by:
main.go
and use clear and specific log messagesAWS_REGION
innode.go
- it's already logged inmain.go
and always logging it there (with a confusing variable name likeregionFromSession
) is misleadingAWS_REGION
if present, even in the node serviceWhat testing is done?
Manual/CI/Updated unit tests
Examples of new output: