Use new client token when CreateVolume returns IdempotentParameterMismatch
#2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/L
ConnorJC3
force-pushed
the
fix-createvolume-idempotency-race-condition
branch
from
dadb2ef to
0aaf246
Compare
Code Coverage Diff
|
ConnorJC3
force-pushed
the
fix-createvolume-idempotency-race-condition
branch
2 times, most recently
from
8725a56 to
f0bb44e
Compare
ConnorJC3
changed the title
CreateVolume returns IdempotentParameterMismatchCreateVolume returns IdempotentParameterMismatch
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/retest |
1 similar comment
|
/retest |
rdpsin
reviewed
Jul 1, 2024
torredil
reviewed
Jul 1, 2024
ConnorJC3
force-pushed
the
fix-createvolume-idempotency-race-condition
branch
2 times, most recently
from
1395040 to
c691175
Compare
Signed-off-by: Connor Catlett <[email protected]>
Signed-off-by: Connor Catlett <[email protected]>
…match Signed-off-by: Connor Catlett <[email protected]>
ConnorJC3
force-pushed
the
fix-createvolume-idempotency-race-condition
branch
from
c691175 to
0a0d5ef
Compare
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndrewSirenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
Fixes #1951
What is this PR about? / Why do we need it?
If
CreateVolumefails for any reason (examples: the user provides an invalid KMS key, due to an EBS-side issue, etc), we retry with the same client token. However, despite the fact that theCreateVolumecall corresponds to a volume that was never created, our client token is burned.In the scenario where we detect this has occurred, this PR tries again with a different token. However, to prevent volume leaks, the token must follow a predictable pattern. To do this, I append
-2to the volume id pre-hashing for the token, and if that request fails, I instead append-3,-4, etc. This is done strictly in order, so a CSI driver that crashes (or restarts for any other reason, such as an upgrade) can consistently reuse the same tokens until it reaches the 'correct' token.To keep track of which token we have most recently used during runtime, I use an expiring cache, similar to the existing "likely bad names" cache implementation. In order to DRY up the code, the first two commits of this PR migrate that implementation to the
utilpackage (commit 1) and then migrate the existinglikelyBadNamesimplementation to use theutilversion (commit 2). Finally, this PR implements the above described change using this cache (commit 3).What testing is done?
Added/updated unit tests, CI, manual