-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --kubeconfig flag for out-of-cluster auth #2081
Add --kubeconfig flag for out-of-cluster auth #2081
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Is this a bug fix or adding new feature?
Feature
What is this PR about? / Why do we need it?
This adds a command-line flag,
--kubeconfig
, that allows an alternative torest.InClusterConfig()
. This is useful when running the CSI driver outside of a Pod.If
--kubeconfig
is empty, the behavior is unchanged.What testing is done?
I see the k8s client instantiated successfully: