Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure ModifyVolume returns InvalidArgument error code if VAC contains invalid parameter #2103

Merged
merged 11 commits into from
Aug 6, 2024
Merged

Ensure ModifyVolume returns InvalidArgument error code if VAC contains invalid parameter #2103

merged 11 commits into from
Aug 6, 2024

Conversation

mdzraf
Copy link
Contributor

@mdzraf mdzraf commented Jul 31, 2024 •
edited
Loading

Is this a bug fix or adding new feature?
Bug fix

What is this PR about? / Why do we need it?
Closes #2099

What testing is done?
Manual testing was done to verify that volume modification does not succeed and error is returned if non-supported parameter is inputted in VAC

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 31, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @mdzraf. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 31, 2024
@ConnorJC3
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 31, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 31, 2024 •
edited
Loading

Code Coverage Diff

File Old Coverage New Coverage Delta
github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/cloud/devicemanager/allocator.go 93.3% 100.0% 6.7
github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/driver/controller_modify_volume.go 72.0% 72.3% 0.3

ConnorJC3
ConnorJC3 reviewed Jul 31, 2024
View reviewed changes
Copy link
Contributor

@ConnorJC3 ConnorJC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2024
@mdzraf mdzraf changed the title Fix for issue #2099 Ensure ModifyVolume returns InvalidArgument error code if VAC contains invalid parameter Jul 31, 2024
torredil
torredil approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ConnorJC3
Copy link
Contributor

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2024
@mdzraf
Copy link
Contributor Author

mdzraf commented Jul 31, 2024

/retest

@ConnorJC3
Copy link
Contributor

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 31, 2024
@torredil
Copy link
Member

/remove-lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 31, 2024
@mdzraf
Copy link
Contributor Author

mdzraf commented Aug 1, 2024

/retest

ConnorJC3
ConnorJC3 reviewed Aug 5, 2024
View reviewed changes
AndrewSirenko
AndrewSirenko reviewed Aug 5, 2024
View reviewed changes
Copy link
Contributor

@AndrewSirenko AndrewSirenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than @torredil and @ConnorJC3's comments

I agree that the annotation logic should be moved into a util/helper method in order to make test easier to read.

Thanks!

ConnorJC3
ConnorJC3 reviewed Aug 6, 2024
View reviewed changes
Copy link
Contributor

@ConnorJC3 ConnorJC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs squash otherwise lgtm

torredil
torredil approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label tide/merge-method-squash
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 40f2d17 into kubernetes-sigs:master Aug 6, 2024
11 checks passed
ElijahQuinones pushed a commit to ElijahQuinones/aws-ebs-csi-driver that referenced this pull request Aug 6, 2024
@mdzraf @zyue110026 @ElijahQuinones
Ensure ModifyVolume returns InvalidArgument error code if VAC contain…
fad6014 
…s invalid parameter (kubernetes-sigs#2103)

* Fixing invalid VAC parameter on modification bug

* Fixing invalid VAC parameter on modification bug

* fix: sidecars.snapshotter.logLevel not being respect

* Fixed e2e tests

* Fixed e2e tests

* fixed unit tests

* fixed unit tests

* moved helper logic to utils

* Moved function to prefix into e2e_utils

---------

Co-authored-by: zyue110026 <[email protected]>
@dfajmon dfajmon mentioned this pull request Sep 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConnorJC3 ConnorJC3 ConnorJC3 left review comments

@AndrewSirenko AndrewSirenko AndrewSirenko approved these changes

@torredil torredil torredil approved these changes

Assignees

@ConnorJC3 ConnorJC3

@AndrewSirenko AndrewSirenko

@torredil torredil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ModifyVolume should not modify PVC via VAC containing unsupported parameters
6 participants
@mdzraf @k8s-ci-robot @ConnorJC3 @torredil @AndrewSirenko @zyue110026