-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dependabot for Go module & GitHub Action dependencies #2179
Add Dependabot for Go module & GitHub Action dependencies #2179
Conversation
Code Coverage DiffThis PR does not change the code coverage |
/retest |
8bdea34
to
7a569d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you /lgtm
7a569d5
to
7b8b0b0
Compare
3c3400d
to
1c69de9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
1c69de9
to
0ddeaf8
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ConnorJC3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
N/A
What is this PR about? / Why do we need it?
Performing all dependency upgrades during the release process leads to delays when a certain upgrade contains breaking changes. Let's decrease the chance of release delays by spreading most of these updates out before we start a release, and automate that work with GitHub's Dependabot. Even better, dependabot cleanly shows release notes, changelogs, and even commits for each dependency it is upgrading in its PR.
See the new
docs/updating-dependencies.md
for an introduction to Dependabot and our project dependencies.Let's start with a weekly cadence. If we find that too many dependencies occur in same PR such that troubleshooting breaking changes becomes challenging, we can switch to daily cadence (Dependabot will ensure only 1 PR per group is up at a time). I chose Wednesday mornings because it is after Windows patch Tuesdays.
I chose Dependabot over some other tool like Renovate because most other K8s projects use Dependabot, it requires no self-hosting because it is built-in to GH, and we don't need Renovate's custom configuration options today.
I will update our internal runbook after this merges.
What testing is done?
See the 3 PRs on my fork that dependabot rose: