Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable VAC feature gate for Kustomize deployments #2240

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

ConnorJC3
Copy link
Contributor

What type of PR is this?

/kind feature

What is this PR about? / Why do we need it?

Fixes #2238

After discussion, we decided for a consistent experience and because the downsides are significant if a user attempts to use it while disabled on the sidecars, we will enable the VAC feature gate for the Kustomize deployment.

How was this change tested?

Manually tested + CI

Does this PR introduce a user-facing change?

[TODO AFTER GENERATING RELEASE NOTES: Move to "Urgent Upgrade Notes" section] Enables the `VolumeAttributesClass` by default for the Kustomize deployment. If you are deploying using the Kustomize manifests on a cluster that does not have the `VolumeAttributesClass` feature gate enabled on the control plane, you may see harmless extra failures related to the feature in the csi-provisioner and/or csi-resizer logs.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 22, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 22, 2024
Copy link

Code Coverage Diff

This PR does not change the code coverage

@AndrewSirenko
Copy link
Contributor

you may see harmless extra failures related to the feature in the csi-provisioner and/or csi-resizer logs

Did we confirm this in the manual test? Or should I spin up a non-VAC enabled cluster

@ConnorJC3
Copy link
Contributor Author

Did we confirm this in the manual test? Or should I spin up a non-VAC enabled cluster

I did a super basic test but extra eyes cannot hurt.

@torredil
Copy link
Member

/retest

@ConnorJC3
Copy link
Contributor Author

/test

@k8s-ci-robot
Copy link
Contributor

@ConnorJC3: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test pull-aws-ebs-csi-driver-e2e-multi-az
  • /test pull-aws-ebs-csi-driver-e2e-single-az
  • /test pull-aws-ebs-csi-driver-external-test
  • /test pull-aws-ebs-csi-driver-external-test-eks
  • /test pull-aws-ebs-csi-driver-test-e2e-external-eks-windows
  • /test pull-aws-ebs-csi-driver-test-helm-chart
  • /test pull-aws-ebs-csi-driver-unit
  • /test pull-aws-ebs-csi-driver-verify

The following commands are available to trigger optional jobs:

  • /test pull-aws-ebs-csi-driver-external-test-arm64

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ConnorJC3
Copy link
Contributor Author

ConnorJC3 commented Nov 22, 2024

Tested make e2e/external-kustomize locally because this PR won't run the kustomize job:

Ran 91 of 6899 Specs in 314.219 seconds
SUCCESS! -- 91 Passed | 0 Failed | 0 Pending | 6808 Skipped

Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2024
@ElijahQuinones
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElijahQuinones

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0301ff3 into kubernetes-sigs:master Nov 25, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix pull-aws-ebs-csi-driver-external-test-kustomize
5 participants