Fix raw pointer log in EnableFastSnapshotRestores
#2334
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What is this PR about? / Why do we need it?
Currently, there is a logging issue in cloud.EnableFastSnapshotRestores which surfaces because the existing code is printing out raw pointers from the error structures rather than their underlying string values. With this cc, we explicitly extract the error code and error message from each failed FSR operation and consolidate them into a single, readable error message.
How was this change tested?
Exceed the regional FSR limit to induce the error, which can be reviewed by looking at the controller logs.
Without this patch:
With this patch:
Does this PR introduce a user-facing change?