-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Logs On How We Calculate CSINode.allocatables in NodeGetInfo #2372
base: master
Are you sure you want to change the base?
Conversation
Hi @mdzraf. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
2f3d31a
to
124e0c2
Compare
124e0c2
to
fce85e4
Compare
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -792,7 +798,9 @@ func (d *NodeService) getVolumesLimit() int64 { | |||
availableAttachments = dedicatedLimit | |||
} else if isNitro { | |||
enis := d.metadata.GetNumAttachedENIs() | |||
klog.V(4).InfoS("getVolumesLimit:", "numeENIs", enis) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: numeENIs
What type of PR is this?
/kind cleanup
What is this PR about? / Why do we need it?
Today we log number of attached ENIs upon driver start if IMDS is our metadata source. However, we accidentally log it even if driver is in controller mode, which is an confusing experience for customers (Why should ebs-csi-controller care about the ENI count of the node it is on?)
This PR removes logging of ENIs when in controller mode and also adds logging of some of the information used to calculate CSI Node Allocatable, this way customers can have a better understanding of how this final node allocatable count was calculated.
How was this change tested?
Manually by spinning up a cluster and checking logs for nodes.
Logs output looks like this:
Does this PR introduce a user-facing change?