docs/README: add missing "--namespace" flag to "helm" command

[gyuho]

No description provided.

[coveralls]

Pull Request Test Coverage Report for Build 1079

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 78.871%

---

Totals
Change from base Build 1078:	0.0%
Covered Lines:	1411
Relevant Lines:	1789

---

💛 - Coveralls

[wongma7]

/lgtm
looks like all the templates have namespace: kube-system set...but I don't see the harm in the helm install command being explicit!

[wongma7]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gyuho, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wongma7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[TBBle]

Would it be worthwhile putting a check in the NOTES.txt that causes a Helm render error if you don't provide a namespace? With Helm v3, the --namespace parameter also sets the namespace used to hold the secrets with the chart data, and so if you set this differently, helm ls will report a different namespace to where all the resources are.

Conversely, does the EBS-CSI driver have to be in kube-system? The other option would be to fix the templates to use {{.Release.Namespace}} so that they are installed wherever the user specifies, which would allow using, e.g. ebs-csi-system, as a namespace for the driver and all its resources.

[wongma7]

No, it doesn't have to be in kube-system. I think helm best practice is to not specify namespace: in the templates at all then the namespace is determined by the --namespace flag or whatever your current kube context is. But I don't keep up with helm and I have to defer to people who actually use it.

[TBBle]

Ah, you are correct, excluding the namespace does do the right thing, and honours the --namespace flag, and the default Helm chart created by helm create does not have namespace metadata fields in its objects.