-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow all fields to be set on StorageClasses #730
Allow all fields to be set on StorageClasses #730
Conversation
Welcome @haines! |
Hi @haines. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pull Request Test Coverage Report for Build 1571
💛 - Coveralls |
parameters: | ||
{{ toYaml . | indent 2 }} | ||
{{- end }} | ||
{{ omit (dict "volumeBindingMode" "WaitForFirstConsumer" | merge .) "name" | toYaml }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL!
/ok-to-test @haines thanks for your contribution! Could you please update the chart version as well? |
49905f6
to
580c0eb
Compare
Thanks for reviewing, @ayberk! I've rebased onto master and bumped the chart version. |
/lgtm Thanks a lot! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ayberk, haines The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
A new feature
What is this PR about? / Why do we need it?
The StorageClasses created by the Helm chart can currently only be configured with
volumeBindingMode
,reclaimPolicy
, andparameters
. We haveallowVolumeExpansion: true
set on ours, so we couldn't migrate them to be provisioned by the chart.This PR allows any field permitted by the API to be specified.
What testing is done?
I've templated the chart with a variety of StorageClasses and validated that the output manifests are correct.