-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resize filesystem when restore a snapshot to larger size volume #753
Resize filesystem when restore a snapshot to larger size volume #753
Conversation
Hi @AndyXiangLi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pull Request Test Coverage Report for Build 1887
💛 - Coveralls |
/ok-to-test |
b3db3b1
to
c181063
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndyXiangLi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8b55a14
to
8c7b5b9
Compare
2240d16
to
68d0eda
Compare
/test pull-aws-ebs-csi-driver-verify |
68d0eda
to
6fe27b7
Compare
6fe27b7
to
31ce352
Compare
@AndyXiangLi did you merge it intentionally? I don't think it was reviewed. :-) cc @wongma7 |
We talked about this offline and decide to merge it for now. Will update once the upstream is merged |
(retroactive) yea, let's merge stuff only when lgtm + approve present. I frequently manually merge stuff when those are present in case coveralls is bugged (it's already marked NOT required, but prow bot treats it as required for some reason), otherwise no reason to manual merge |
Is this a bug fix or adding new feature?
Fixes: #569
What is this PR about? / Why do we need it?
continue from #595
Before NodePublishVolume, we will check if the device size is matched with the usable filesystem size. And resize the filesystem if there is a mismatch
TODO: Upstream is planning on move the common resize code to kubernetes/mount-util, #99223, we should use the resize function from there instead of maintaining our own once the changes are available
What testing is done?
Test done in both ext[x] and xfs filesystem