Aws client config: increase MaxRetries

[josselin-c]

This commit increase the number of retries to a high number (8) so
that the AWS framework retries failing requests until the request
context times-out.

By default, when throttled, the aws client retries a given request
3 times with exponentially increasing delay between retries.
The default number of retries is still low enough that requests are
only going to be retried for a few seconds.
Instead of retrying for a few seconds, we should retry until the
request context times out.

This should reduce the occurence of #754

Is this a bug fix or adding new feature?
Mitigation for #754

*What is this PR about? / Why do we need it?
waitForVolume has a checkTime of 1 minute but current AWS client only retries requests for a few seconds.

This PR is about increasing the number of retries the AWS client performs before giving up so that waitForVolume actually waits a full minute or until the request context deadline is reached.

This is important because as explained in #754 a throttled / failed request will result in a leaked volume so we want to reduce the change of it happening.

What testing is done?
make test

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @josselin-c!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @josselin-c. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[coveralls]

Pull Request Test Coverage Report for Build 1633

• 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.08%) to 81.579%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/cloud/cloud.go	0	2	0.0%

Totals
Change from base Build 1626:	-0.08%
Covered Lines:	1736
Relevant Lines:	2128

---

💛 - Coveralls

[wongma7]

/ok-to-test

[wongma7]

/approve

w8ing on cla

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josselin-c, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wongma7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[josselin-c]

cla signed

[wongma7]

/lgtm

will manual merge if bot complains about coveralls *

[wongma7]

FYI @ayberk as I know you are following #754 and we are gonna need to discuss how to make the same fix in in-tree cloudprovider and maybe in out-of-tree cloudprovider v2 API that could be consumed by this driver.