-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add options to enable aws sdk debug log and add more logs when driver… #830
add options to enable aws sdk debug log and add more logs when driver… #830
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndyXiangLi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 1840
💛 - Coveralls |
30d49ad
to
dcde556
Compare
/test pull-aws-ebs-csi-driver-unit |
dcde556
to
22e20e6
Compare
pkg/driver/mocks/mock_cloud.go
Outdated
) | ||
|
||
// MockCloud is a mock of Cloud interface. | ||
// MockEC2 is a mock of EC2 interface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how come it's mocking ec2 interface now? the ec2 mock should go to mock_ec2.go (looking at script https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/hack/update-gomock#L21)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting.. Can you try on your end? I just ran make bin/mockgen under project root path and get this EC2 mock added into the mock_cloud.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried with latest mockgen, it only changed my go.sum : /
~/g/s/g/k/aws-ebs-csi-driver (master|✔) $ rm bin/mockgen
~/g/s/g/k/aws-ebs-csi-driver (master|✔) $ make mockgen
go get github.com/golang/mock/mockgen@latest
go: found github.com/golang/mock/mockgen in github.com/golang/mock v1.5.0
go: downloading golang.org/x/tools v0.0.0-20191119224855-298f0cb1881e
go: downloading golang.org/x/mod v0.3.0
./hack/update-gomock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
figured that out.. I didn't specify the interface name when I ran the command.. updated now
22e20e6
to
79e9ff0
Compare
/test pull-aws-ebs-csi-driver-migration-test-latest |
@ayberk migration test is consistently failing the first time, any thoughts? |
/lgtm |
… start up
Is this a bug fix or adding new feature?
Fixes #216
What is this PR about? / Why do we need it?
Add a new driver level option -aws-sdk-debug-log, if set to true, aws go sdk will add debug log to the std output.
Sample for debug log
Also adjust and update the klog level across driver.
What testing is done?
unit test
e2e test