-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eksctl support to e2e scripts #852
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -57,26 +52,27 @@ function kops_create_cluster() { | |||
kops_patch_cluster_file "$CLUSTER_FILE" "$KOPS_PATCH_FILE" | |||
|
|||
loudecho "Creating cluster $CLUSTER_NAME with $CLUSTER_FILE" | |||
${KOPS_BIN} create --state "${KOPS_STATE_FILE}" -f "${CLUSTER_FILE}" | |||
${BIN} create --state "${KOPS_STATE_FILE}" -f "${CLUSTER_FILE}" | |||
kops create secret --state "${KOPS_STATE_FILE}" --name "${CLUSTER_NAME}" sshpublickey admin -i "${SSH_KEY_PATH}".pub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is unrelated change, cuz I found out while testing "kops update cluster --state "${KOPS_STATE_FILE}" "${CLUSTER_NAME}"
--ssh-public-key="${SSH_KEY_PATH}".pub --yes" is deprecated:
--ssh-public-key string SSH public key to use (deprecated: use kops create secret instead)
Pull Request Test Coverage Report for Build 1932
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, some small comments.
/lgtm |
coveralls bugged (did not touc hgo code), manual merge |
Is this a bug fix or adding new feature? testing
What is this PR about? / Why do we need it? Would like to test the driver on eks in addition to kops. eksctl command is similar enough to kops that I think the easiest way is to add a short eksctl script (eksctl.sh) like kops.sh
implementation detail differences:
kops update --yes
. for kops, first you update the state file in s3 then run update --yes to actually update the cluster resources, eksctl it happens at once, there is no state file?What testing is done?
tested locally:
Will let CI test that i haven't broken the existing kops job. Will add an eks prow job later and then work on fixing it in future PR.