Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.25] chore: fix gRPC-Go HTTP/2 Rapid Reset vulnerability #4865

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

feiskyer
Copy link
Member

@feiskyer feiskyer commented Oct 27, 2023

This is a partial cherry-pick of #4847

fix gRPC-Go HTTP/2 Rapid Reset vulnerability

Notes:

  • because of circular dependencies from k8s.io/apiserver and opentelemetry, the OpenTelemetry-Go Contrib CVE-2023-45142 fixes couldn't be updated in this release version.
  • Kubernetes project has decided not to cherry-pick this as well because it is not using the impacted files/methods:

Good news is the files/methods in question in the PR are NOT in our vendor/ directory. Though the advisory claims affected program has to use otelhttp.NewHandler wrapper (which we do have reference of! here) we do not have/use otelhttp metrics related code. So we are not affected AFAICT.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/needs-kind size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 27, 2023
@feiskyer
Copy link
Member Author

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind labels Oct 27, 2023
@feiskyer feiskyer changed the title [release-1.25] chore: fix OpenTelemetry-Go Contrib CVE-2023-45142 [release-1.25] chore: fix gRPC-Go HTTP/2 Rapid Reset vulnerability Oct 27, 2023
@MartinForReal
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2023
@feiskyer
Copy link
Member Author

As described above, trivy scanning failure is expected due to unable bump opentelemetry version.

@feiskyer feiskyer merged commit c816eb1 into kubernetes-sigs:release-1.25 Oct 28, 2023
@feiskyer feiskyer deleted the 4847-25 branch October 28, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants