fix: Do not move nodes that have already been attached to load balanc… #6965
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
approved
nilo19
force-pushed
the
fix/multi-slb-node
branch
4 times, most recently
from
5a603a8 to
01f3d9f
Compare
nilo19
force-pushed
the
fix/multi-slb-node
branch
from
01f3d9f to
beab47c
Compare
pkg/provider/azure_loadbalancer.go
Outdated
| ) error { | ||
| if init { | ||
| if err := az.recordExistingNodesOnLoadBalancers(clusterName, lbs); err != nil { | ||
| fmt.Println(err) |
There was a problem hiding this comment.
Thanks for the catch.
| if strings.EqualFold(trimSuffixIgnoreCase( | ||
| lbName, consts.InternalLoadBalancerNameSuffix, | ||
| ), multiSLBConfig.Name) { | ||
| az.MultipleStandardLoadBalancerConfigurations[i].ActiveNodes = |
There was a problem hiding this comment.
Is ActiveNodes the node distribution cache you mentioned in the PR description?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, nilo19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ers after restarting When using multislb, the node distribution could be changed after restarting the ccm. This is because the node distribution cache would be lost after restarting. This PR restores the node distribution each time the ccm is restarted.
nilo19
force-pushed
the
fix/multi-slb-node
branch
from
beab47c to
940b753
Compare
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
1 similar comment
|
/retest |
|
/cherrypick release-1.31 |
|
@nilo19: new pull request created: #7021 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick release-1.30 |
|
@nilo19: new pull request created: #7022 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick release-1.29 |
|
/cherrypick release-1.28 |
|
@nilo19: new pull request created: #7023 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@nilo19: new pull request created: #7024 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix: Do not move nodes that have already been attached to load balancers after restarting
When using multislb, the node distribution could be changed after restarting the ccm. This is because the node distribution cache would be lost after restarting. This PR restores the node distribution each time the ccm is restarted.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This only affects cluster services.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: