feat: Lock updates on azure resources when other component is doing t…

[nilo19]

…he same thing.

This PR utilizes a lease in each service reconciliation to prevent race conditions where cloud provider and others are updating the same azure resources.

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR utilizes a lease in each service reconciliation to prevent race conditions where cloud provider and others are updating the same azure resources. If the lease has not expired yet and is held by other component, the service reconciliation will be aborted and retried exponentially.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

feat: Lock updates on azure resources when other component is doing the same thing.

This PR utilizes a lease in each service reconciliation to prevent race conditions where cloud provider and others are updating the same azure resources.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[zarvd]

I’m curious about which component would access the same Azure resource simultaneously, and exactly which resource is it? It seems like the lock covers the entire EnsureLoadBalancer.

[nilo19]

I’m curious about which component would access the same Azure resource simultaneously, and exactly which resource is it? It seems like the lock covers the entire EnsureLoadBalancer.

AKS RP may have conflicts with cloud provider.

[nilo19]

Invalidates cache if the previous holder is another component. We can invalidate more caches here if needed.

[feiskyer]

we'd need clear caches for vmss, vmssvm and vm

[nilo19]

Added.

[coveralls]

coverage: 76.787% (+0.04%) from 76.75%
when pulling a8a619b on nilo19:feat/multi-slb/lock
into ac0079b on kubernetes-sigs:master.

[feiskyer]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [feiskyer,nilo19]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nilo19]

/retest

[nilo19]

/retest

[nilo19]

E1012 01:41:09.094776 1 controllermanager.go:93] Run: failed to configure cloud controller manager: --cloud-config cannot be empty when --enable-dynamic-reloading is not set to true

[nilo19]

/retest

[nilo19]

/retest

[nilo19]

/retest

[feiskyer]

/lgtm

[nilo19]

/cherrypick release-1.31

[k8s-infra-cherrypick-robot]

@nilo19: #7193 failed to apply on top of branch "release-1.31":

Applying: feat: Lock updates on azure resources when other component is doing the same thing.
Using index info to reconstruct a base tree...
M	go.sum
M	pkg/provider/azure.go
M	pkg/provider/azure_loadbalancer.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/provider/azure_loadbalancer.go
Auto-merging pkg/provider/azure.go
Auto-merging go.sum
Applying: invalidate vmset caches when locking
Using index info to reconstruct a base tree...
M	pkg/provider/azure_mock_vmsets.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/provider/azure_mock_vmsets.go
CONFLICT (content): Merge conflict in pkg/provider/azure_mock_vmsets.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0002 invalidate vmset caches when locking

In response to this:

/cherrypick release-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[MartinForReal]

/cherrypick release-1.30

[k8s-infra-cherrypick-robot]

@MartinForReal: #7193 failed to apply on top of branch "release-1.30":

Applying: feat: Lock updates on azure resources when other component is doing the same thing.
Using index info to reconstruct a base tree...
M	cmd/cloud-controller-manager/app/controllermanager.go
M	go.sum
M	pkg/consts/consts.go
M	pkg/node/node.go
M	pkg/node/nodearm.go
M	pkg/provider/azure.go
M	pkg/provider/azure_loadbalancer.go
M	pkg/provider/azure_loadbalancer_test.go
Falling back to patching base and 3-way merge...
CONFLICT (add/add): Merge conflict in pkg/provider/azure_lock.go
Auto-merging pkg/provider/azure_lock.go
Auto-merging pkg/provider/azure_loadbalancer_test.go
CONFLICT (content): Merge conflict in pkg/provider/azure_loadbalancer_test.go
Auto-merging pkg/provider/azure_loadbalancer.go
Auto-merging pkg/provider/azure.go
Auto-merging go.sum
Auto-merging cmd/cloud-controller-manager/app/controllermanager.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 feat: Lock updates on azure resources when other component is doing the same thing.

In response to this:

/cherrypick release-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[MartinForReal]

/cherrypick release-1.30

[k8s-infra-cherrypick-robot]

@MartinForReal: #7193 failed to apply on top of branch "release-1.30":

Applying: feat: Lock updates on azure resources when other component is doing the same thing.
Using index info to reconstruct a base tree...
M	cmd/cloud-controller-manager/app/controllermanager.go
M	go.sum
M	pkg/consts/consts.go
M	pkg/node/node.go
M	pkg/node/nodearm.go
M	pkg/provider/azure.go
M	pkg/provider/azure_loadbalancer.go
M	pkg/provider/azure_loadbalancer_test.go
Falling back to patching base and 3-way merge...
CONFLICT (add/add): Merge conflict in pkg/provider/azure_lock.go
Auto-merging pkg/provider/azure_lock.go
Auto-merging pkg/provider/azure_loadbalancer_test.go
CONFLICT (content): Merge conflict in pkg/provider/azure_loadbalancer_test.go
Auto-merging pkg/provider/azure_loadbalancer.go
Auto-merging pkg/provider/azure.go
Auto-merging go.sum
Auto-merging cmd/cloud-controller-manager/app/controllermanager.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 feat: Lock updates on azure resources when other component is doing the same thing.

In response to this:

/cherrypick release-1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.