Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.32] Fix: Preserve Whitespace for Tag Values Resembling "null" to Prevent ARM Assignment Errors #8229

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #8071

/assign nilo19

Tags with values resembling "null" (e.g., " null " or " NuLL ") will now retain their leading and trailing whitespace during inheritance or updates to avoid errors caused by ARM's reserved tag value "null". 
This change only affects tags with such specific values, ensuring all other tags continue to have whitespace trimmed as before.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 5, 2025
@nilo19
Copy link
Contributor

nilo19 commented Feb 5, 2025

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind labels Feb 5, 2025
@nilo19
Copy link
Contributor

nilo19 commented Feb 5, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 5, 2025
@coveralls
Copy link

Coverage Status

coverage: 74.26% (+0.008%) from 74.252%
when pulling 25f6858 on k8s-infra-cherrypick-robot:cherry-pick-8071-to-release-1.32
into b0312a1 on kubernetes-sigs:release-1.32.

@nilo19
Copy link
Contributor

nilo19 commented Feb 5, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2025
@nilo19
Copy link
Contributor

nilo19 commented Feb 5, 2025

/retest

1 similar comment
@nilo19
Copy link
Contributor

nilo19 commented Feb 6, 2025

/retest

@k8s-ci-robot k8s-ci-robot merged commit 78f942d into kubernetes-sigs:release-1.32 Feb 6, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants