Chores: set go.mod in main to 1.24 and one in azclient to 1.23.6 #8376
Conversation
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MartinForReal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
There was a problem hiding this comment.
Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (3)
- .github/workflows/dependency-review.yml: Language not supported
- .github/workflows/lint.yaml: Language not supported
- go.mod: Language not supported
MartinForReal
force-pushed
the
shafan/go
branch
6 times, most recently
from
e4e76ce to
89f01cd
Compare
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
MartinForReal
force-pushed
the
shafan/go
branch
2 times, most recently
from
ee12f41 to
414ede0
Compare
|
/retest |
1 similar comment
|
/retest |
|
@MartinForReal could you check why all tests are failing? |
|
Feb 19 12:19:49.800021 capz-xl2x8u-control-plane-bvk7r kubelet[1664]: E0219 12:19:49.799898 1664 pod_workers.go:1301] "Error syncing pod, skipping" err="failed to "StartContainer" for "kube-apiserver" with CrashLoopBackOff: "back-off 1m20s restarting failed container=kube-apiserver pod=kube-apiserver-capz-xl2x8u-control-plane-bvk7r_kube-system(3331e7094b62eb3737eb8f15c80098c3)"" pod="kube-system/kube-apiserver-capz-xl2x8u-control-plane-bvk7r" podUID="3331e7094b62eb3737eb8f15c80098c3" |
|
apiserver crashed. |
MartinForReal
force-pushed
the
shafan/go
branch
from
414ede0 to
5f9c829
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
MartinForReal
force-pushed
the
shafan/go
branch
2 times, most recently
from
56ef0be to
03026da
Compare
MartinForReal
force-pushed
the
shafan/go
branch
5 times, most recently
from
973d456 to
3fab92d
Compare
MartinForReal
changed the title
|
/test all |
MartinForReal
force-pushed
the
shafan/go
branch
7 times, most recently
from
7938883 to
e21e55e
Compare
Signed-off-by: Fan Shang Xiang <[email protected]>
MartinForReal
force-pushed
the
shafan/go
branch
from
e21e55e to
7b96e41
Compare
|
/retest |
The PR is actually upgrading Go to 1.24. Could you we use 1.23.6 until k8s repos officially support it? |
| @@ -103,14 +197,3 @@ jobs: | |||
| with: | |||
| sarif_file: 'trivy-health-probe-proxy-linux-results.sarif' | |||
| category: health-probe-proxy-linux-image | |||
|
|
|||
| - name: Run Trivy vulnerability scanner in repo mode | |||
There was a problem hiding this comment.
And why making such huge change to github pipelines? I think we should scan the whole repo
There was a problem hiding this comment.
please see line 65
All these actions share two steps: checkout and setup go.
It will save time.
kubernetes/kubernetes#129688 this pr has been approved. |
|
that's not merged yet, and full e2e tests are not run yet. Let's wait a while for community validations in case there are breaking changes or behavior changes broken k8s. /hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
@MartinForReal: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind testing
What this PR does / why we need it:
Chores: set go to 1.23.6
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: