Test for AWSMachine & AWSCluster granularity switches

kubernetes-sigs · Feb 20, 2025 · 4bb5a08 · 4bb5a08
1 parent 21012cb
commit 4bb5a08
Show file tree

Hide file tree

Showing 2 changed files with 94 additions and 0 deletions.
diff --git a/test/e2e/shared/workload.go b/test/e2e/shared/workload.go
@@ -168,6 +168,28 @@ func DisableAlternativeGCStrategy(dep *appsv1.Deployment) (*appsv1.Deployment, e
 	return nil, fmt.Errorf("fail to find AlternativeGCStrategy to disable")
 }
 
+// DisableAWSCluster disables AWSCluster in CAPA controller manager args field.
+func DisableAWSCluster(dep *appsv1.Deployment) (*appsv1.Deployment, error) {
+	for i, arg := range dep.Spec.Template.Spec.Containers[0].Args {
+		if strings.Contains(arg, "feature-gates") && strings.Contains(arg, "AWSCluster") {
+			dep.Spec.Template.Spec.Containers[0].Args[i] = strings.Replace(arg, "AWSCluster=true", "AWSCluster=false", 1)
+			return dep, nil
+		}
+	}
+	return nil, fmt.Errorf("fail to find AWSCluster to disable")
+}
+
+// DisableAWSMachine disables AWSMachine in CAPA controller manager args field.
+func DisableAWSMachine(dep *appsv1.Deployment) (*appsv1.Deployment, error) {
+	for i, arg := range dep.Spec.Template.Spec.Containers[0].Args {
+		if strings.Contains(arg, "feature-gates") && strings.Contains(arg, "AWSMachine") {
+			dep.Spec.Template.Spec.Containers[0].Args[i] = strings.Replace(arg, "AWSMachine=true", "AWSMachine=false", 1)
+			return dep, nil
+		}
+	}
+	return nil, fmt.Errorf("fail to find AWSMachine to disable")
+}
+
 // ValidateAlternativeGCStrategyEnabled validates AlternativeGCStrategy in CAPA controller manager args field is set to true.
 func ValidateAlternativeGCStrategyEnabled(dep *appsv1.Deployment) error {
 	for _, arg := range dep.Spec.Template.Spec.Containers[0].Args {
@@ -187,3 +209,43 @@ func ValidateAlternativeGCStrategyDisabled(dep *appsv1.Deployment) error {
 	}
 	return fmt.Errorf("fail to validate AlternativeGCStrategy set to false")
 }
+
+// ValidateAWSClusterEnabled validates AWSCluster in CAPA controller manager args field is set to true.
+func ValidateAWSClusterEnabled(dep *appsv1.Deployment) error {
+	for _, arg := range dep.Spec.Template.Spec.Containers[0].Args {
+		if strings.Contains(arg, "feature-gates") && strings.Contains(arg, "AWSCluster=true") {
+			return nil
+		}
+	}
+	return fmt.Errorf("fail to validate AWSCluster set to true")
+}
+
+// ValidateAWSClusterDisabled validates AWSCluster in CAPA controller manager args field is set to false.
+func ValidateAWSClusterDisabled(dep *appsv1.Deployment) error {
+	for _, arg := range dep.Spec.Template.Spec.Containers[0].Args {
+		if strings.Contains(arg, "feature-gates") && strings.Contains(arg, "AWSCluster=false") {
+			return nil
+		}
+	}
+	return fmt.Errorf("fail to validate AWSCluster set to false")
+}
+
+// ValidateAWSMachineEnabled validates AWSMachine in CAPA controller manager args field is set to true.
+func ValidateAWSMachineEnabled(dep *appsv1.Deployment) error {
+	for _, arg := range dep.Spec.Template.Spec.Containers[0].Args {
+		if strings.Contains(arg, "feature-gates") && strings.Contains(arg, "AWSMachine=true") {
+			return nil
+		}
+	}
+	return fmt.Errorf("fail to validate AWSMachine set to true")
+}
+
+// ValidateAWSMachineDisabled validates AWSMachine in CAPA controller manager args field is set to false.
+func ValidateAWSMachineDisabled(dep *appsv1.Deployment) error {
+	for _, arg := range dep.Spec.Template.Spec.Containers[0].Args {
+		if strings.Contains(arg, "feature-gates") && strings.Contains(arg, "AWSMachine=false") {
+			return nil
+		}
+	}
+	return fmt.Errorf("fail to validate AWSMachine set to false")
+}
diff --git a/test/e2e/suites/unmanaged/unmanaged_CAPI_test.go b/test/e2e/suites/unmanaged/unmanaged_CAPI_test.go
@@ -221,4 +221,36 @@ var _ = ginkgo.Context("[unmanaged] [Cluster API Framework]", func() {
 			shared.ReleaseResources(requiredResources, ginkgo.GinkgoParallelProcess(), flock.New(shared.ResourceQuotaFilePath))
 		})
 	})
+
+	ginkgo.It("Feature Flags - AWSMachine and AWSCluster are enabled by default", func() {
+		deployment, getErr := shared.GetDeployment(ctx, shared.GetDeploymentInput{
+			Getter:    e2eCtx.Environment.BootstrapClusterProxy.GetClient(),
+			Name:      "capa-controller-manager",
+			Namespace: "capa-system",
+		})
+		Expect(getErr).To(BeNil())
+		Expect(shared.ValidateAWSClusterEnabled(deployment)).To(BeNil())
+		Expect(shared.ValidateAWSMachineEnabled(deployment)).To(BeNil())
+	})
+
+	ginkgo.It("Feature Flags - AWSCluster disabled", func() {
+		shared.ReconfigureDeployment(ctx, shared.ReconfigureDeploymentInput{
+			Getter:       e2eCtx.Environment.BootstrapClusterProxy.GetClient(),
+			ClientSet:    e2eCtx.Environment.BootstrapClusterProxy.GetClientSet(),
+			Name:         "capa-controller-manager",
+			Namespace:    "capa-system",
+			WaitInterval: e2eCtx.E2EConfig.GetIntervals("", "wait-deployment-ready"),
+		}, shared.DisableAWSCluster, shared.ValidateAWSClusterDisabled)
+	})
+
+	ginkgo.It("Feature Flags - AWSMachine disabled", func() {
+		shared.ReconfigureDeployment(ctx, shared.ReconfigureDeploymentInput{
+			Getter:       e2eCtx.Environment.BootstrapClusterProxy.GetClient(),
+			ClientSet:    e2eCtx.Environment.BootstrapClusterProxy.GetClientSet(),
+			Name:         "capa-controller-manager",
+			Namespace:    "capa-system",
+			WaitInterval: e2eCtx.E2EConfig.GetIntervals("", "wait-deployment-ready"),
+		}, shared.DisableAWSMachine, shared.ValidateAWSMachineDisabled)
+	})
+
 })