Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 EKS Security Group tag updation from AWSManagedControlPlane #5229

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

🌱 EKS Security Group tag updation from AWSManagedControlPlane #5229

wants to merge 3 commits into from

Conversation

vishu2498
Copy link
Contributor

@vishu2498 vishu2498 commented Nov 25, 2024 •
edited by Ankitasw
Loading

What type of PR is this?

/kind feature
/kind bug

What this PR does / why we need it:

This PR implements the functionality of having the same tags everywhere in EKS cluster which are provided in spec.additionalTags section of AWSManagedControlPlane to the default cluster security group of EKS created by AWS.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

For this bug: #5223

Release note:

EKS Security Group tag updation from AWSManagedControlPlane

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/bug Categorizes issue or PR as related to a bug. labels Nov 25, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Nov 25, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @vishu2498. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 25, 2024
Ankitasw
Ankitasw reviewed Nov 26, 2024
View reviewed changes
Copy link
Member

@Ankitasw Ankitasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vishu2498 thanks for the PR, could you please write unit tests for this as well?

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 27, 2024
@vishu2498
Copy link
Contributor Author

@Ankitasw I have added tests to PR.

@vishu2498
Copy link
Contributor Author

@Ankitasw Can you please re-check the PR? I have updated it.

@vishu2498
Copy link
Contributor Author

HI @Ankitasw . Can you please check the PR again?

@Ankitasw
Copy link
Member

Ankitasw commented Dec 5, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitasw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2024
@vishu2498
Copy link
Contributor Author

/test pull-cluster-api-provider-aws-test

@k8s-ci-robot
Copy link
Contributor

@vishu2498: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-cluster-api-provider-aws-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2024
@vishu2498
Copy link
Contributor Author

Hi @Ankitasw . Can you please re-approve and merge this PR?

@vishu2498
Copy link
Contributor Author

@Ankitasw Can you please check it once again?

@vishu2498
Copy link
Contributor Author

Hello @Ankitasw
Can you please re-check this PR?

@vishu2498
Copy link
Contributor Author

@Ankitasw any help on this?

@vishu2498
Copy link
Contributor Author

@Ankitasw @dlipovetsky @luthermonson Can we please get help on this?

@Ankitasw
Copy link
Member

Ankitasw commented Jan 3, 2025

@vishu2498 please update release notes, you can take reference from other PRs

@Ankitasw Ankitasw added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 10, 2025
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 10, 2025
@Ankitasw Ankitasw changed the title EKS Security Group tag updation from AWSManagedControlPlane 🌱 EKS Security Group tag updation from AWSManagedControlPlane Feb 10, 2025
@Ankitasw
Copy link
Member

/test ?

@k8s-ci-robot
Copy link
Contributor

@Ankitasw: The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-aws-build

/test pull-cluster-api-provider-aws-build-docker

/test pull-cluster-api-provider-aws-test

/test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-aws-apidiff-main

/test pull-cluster-api-provider-aws-e2e

/test pull-cluster-api-provider-aws-e2e-blocking

/test pull-cluster-api-provider-aws-e2e-clusterclass

/test pull-cluster-api-provider-aws-e2e-conformance

/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts

/test pull-cluster-api-provider-aws-e2e-eks

/test pull-cluster-api-provider-aws-e2e-eks-gc

/test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-aws-apidiff-main

pull-cluster-api-provider-aws-build

pull-cluster-api-provider-aws-build-docker

pull-cluster-api-provider-aws-test

pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Ankitasw
Copy link
Member

/test pull-cluster-api-provider-aws-e2e-eks

@Ankitasw
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2025
AndiDog
AndiDog reviewed Feb 12, 2025
View reviewed changes
Copy link
Contributor

@AndiDog AndiDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test needs rework

pkg/cloud/services/eks/securitygroup_test.go
GroupId: sampleEKSecurityGroupID,
}, nil)

_, err = ec2Mock.CreateSecurityGroup(createSGinput)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot call the mock methods yourself in a test. They're supposed to be called by CAPA code.

@Ankitasw Ankitasw removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndiDog AndiDog AndiDog left review comments

@Ankitasw Ankitasw Ankitasw left review comments

@dlipovetsky dlipovetsky Awaiting requested review from dlipovetsky

@luthermonson luthermonson Awaiting requested review from luthermonson

Assignees

@Ankitasw Ankitasw

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vishu2498 @k8s-ci-robot @Ankitasw @AndiDog