Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add AWSMachines to back the EC2 instances in AWSMachinePools and AWSManagedMachinePools #5319

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

✨ Add AWSMachines to back the EC2 instances in AWSMachinePools and AWSManagedMachinePools #5319

wants to merge 1 commit into from
+606 −71

Conversation

AndiDog
Copy link
Contributor

@AndiDog AndiDog commented Jan 22, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Replaces #5174 because of branch issues.

This implements the CAPI MachinePool Machines proposal.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4184

Special notes for your reviewer:

Revival of #4527. I took @cnmcavoy's great effort and got it fully working. I tested EC2 cluster creation, machine deletion by user, instance creation and termination by ASG scaling, instance termination by user, ...

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

Add AWSMachines to back the EC2 instances in AWSMachinePools and AWSManagedMachinePools

/assign cnmcavoy
(original author)
/assign richardcase

(CC @sl1pm4t since you were on the previous instance of this PR)

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 22, 2025
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 22, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from andidog. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-priority size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 22, 2025
@AndiDog
Copy link
Contributor Author

AndiDog commented Jan 22, 2025

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

@AndiDog AndiDog force-pushed the awsmachinepool-awsmachines branch from 3ff118b to 3b9f60f Compare January 22, 2025 17:24
@AndiDog
Copy link
Contributor Author

AndiDog commented Jan 22, 2025

/test pull-cluster-api-provider-aws-e2e

@AndiDog
Copy link
Contributor Author

AndiDog commented Jan 23, 2025

/test pull-cluster-api-provider-aws-e2e-eks

fiunchinho
fiunchinho reviewed Jan 27, 2025
View reviewed changes
Copy link
Contributor

@fiunchinho fiunchinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from Richard's open question, looks good to me

@AndiDog AndiDog mentioned this pull request Jan 28, 2025
Open
@AndiDog AndiDog force-pushed the awsmachinepool-awsmachines branch from 3b9f60f to 8a28998 Compare January 28, 2025 11:16
@AndiDog AndiDog force-pushed the awsmachinepool-awsmachines branch from 8a28998 to 170c635 Compare January 28, 2025 12:44
fiunchinho
fiunchinho approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@fiunchinho fiunchinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2025
@AndiDog
Copy link
Contributor Author

AndiDog commented Jan 29, 2025

Test logs gone??

/test pull-cluster-api-provider-aws-e2e

@richardcase
Copy link
Member

/test pull-cluster-api-provider-aws-e2e-eks

@AndiDog
Copy link
Contributor Author

AndiDog commented Feb 6, 2025

@richardcase Tests have passed

@Ankitasw
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardcase richardcase richardcase left review comments

@fiunchinho fiunchinho fiunchinho approved these changes

@faiq faiq Awaiting requested review from faiq

Assignees

@richardcase richardcase

@fiunchinho fiunchinho

@cnmcavoy cnmcavoy

@Ankitasw Ankitasw

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement MachinePool Machines clusterAPI proposal
6 participants
@AndiDog @k8s-ci-robot @richardcase @Ankitasw @fiunchinho @cnmcavoy