🌱 ROSA Modified rosacontrolplane_controller version error messages.

[tinaafitz]

What type of PR is this?
cleanup

What this PR does / why we need it:
The current error messages don't accurately reflect the error.
return fmt.Sprintf("version %s is not supported", version), nil
return "", fmt.Errorf("failed to check if version is valid: %w", err)

Modified the error messages to indicate there's a problem with the combination of version and channelgroup.

Release note:

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign muraee for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• controlplane/rosa/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @tinaafitz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[damdo]

Hey @tinaafitz thanks for your PR.
Just a nit

[damdo]

@tinaafitz any thoughts on the review?

[tinaafitz]

Hi @damdo,

Thank you for the review. I modified the messages as requested. :-)

[damdo]

/release-note-none

[damdo]

/ok-to-test

[damdo]

Thanks @tinaafitz

/lgtm

/assign @nrb

[damdo]

/assign @serngawy

[tinaafitz]

Thanks @damdo. :-)

[serngawy]

@tinaafitz let's add ROSA in PR title, we should do that for all work related to ROSA

[tinaafitz]

Thanks, @serngawy. Added ROSA to the PR title.