Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NAT64 network source #4593

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

johannwagner
Copy link
Contributor

@johannwagner johannwagner commented Jul 5, 2024

Description

We run an IPv6 only Kubernetes cluster environment and designated a /96 IPv6 network to map to an IPv4 address space in a casual NAT64 setup. Therefore, we need to create an A record for each AAAA record within this address room.

We added an additional source wrapper, similar to DedupSource and added a config value for the NAT64 prefixes. The source wrapper looks at all AAAA records and translates them - if applicable - into A records.
We also added unit tests for that.

Note: I did not add any enduser documentation, because I was not sure where to put this part specifically. If you can give me a pointer, I would be happy to add this.

Checklist

  • Unit tests updated
  • End user documentation updated

Copy link

linux-foundation-easycla bot commented Jul 5, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 5, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @johannwagner!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 5, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @johannwagner. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 5, 2024
@k8s-ci-robot k8s-ci-robot requested review from mloiseleur and szuecs July 5, 2024 06:45
@johannwagner
Copy link
Contributor Author

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 5, 2024
@mloiseleur
Copy link
Contributor

It's very interesting, thanks 👍.
For the documentation, there is a source tab, see here. Wdyt of adding a new doc in this section ?
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 9, 2024
@johannwagner
Copy link
Contributor Author

Thanks!

I will add docs on Monday, currently on vacation. 🙌

@johannwagner
Copy link
Contributor Author

Since it is not really a source-based addition and should work for all sources, I would rather put it in the Advanced Topic section after some consideration.

@johannwagner
Copy link
Contributor Author

Added some documentation, I also tried to give a usage example but it's very networky and probably a niece topic anyways.

@mloiseleur
Copy link
Contributor

/retitle feat: NAT64 network source
/lgtm

@k8s-ci-robot k8s-ci-robot changed the title Introduced NAT64 prefix rewriting feat: NAT64 network source Aug 19, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2024
@szuecs
Copy link
Contributor

szuecs commented Sep 5, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 848e309 into kubernetes-sigs:master Sep 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants