-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: NAT64 network source #4593
feat: NAT64 network source #4593
Conversation
Welcome @johannwagner! |
Hi @johannwagner. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/easycla |
5112640
to
27bd830
Compare
It's very interesting, thanks 👍. |
Thanks! I will add docs on Monday, currently on vacation. 🙌 |
Since it is not really a source-based addition and should work for all sources, I would rather put it in the Advanced Topic section after some consideration. |
Added some documentation, I also tried to give a usage example but it's very networky and probably a niece topic anyways. |
53ad666
to
5c7a69f
Compare
5c7a69f
to
1b4843a
Compare
/retitle feat: NAT64 network source |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: szuecs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
We run an IPv6 only Kubernetes cluster environment and designated a /96 IPv6 network to map to an IPv4 address space in a casual NAT64 setup. Therefore, we need to create an A record for each AAAA record within this address room.
We added an additional source wrapper, similar to
DedupSource
and added a config value for the NAT64 prefixes. The source wrapper looks at all AAAA records and translates them - if applicable - into A records.We also added unit tests for that.
Note: I did not add any enduser documentation, because I was not sure where to put this part specifically. If you can give me a pointer, I would be happy to add this.
Checklist