fix(Google DNS): ensure trailing dot on NS records

[abaguas]

Description

NS records added in Google Cloud DNS must have a trailing dot. Otherwise the API throws the following error:

time="2024-11-04T10:34:20Z" level=error msg="googleapi: Error 400: Invalid value for 'entity.change.additions[cloud.k8gb.io.][NS].rrdata[0]': 'gslb-ns-eu-cloud.k8gb.io', invalid"

This is similar to CNAME, MX and SRV records.

---

This change was tested with the a DNSEndpoint CRD containing the following endpoints:

    endpoints:
    - dnsName: cloud.k8gb.io
      recordTTL: 5
      recordType: NS
      targets:
      - gslb-ns-eu-cloud.k8gb.io
      - gslb-ns-us-cloud.k8gb.io
    - dnsName: gslb-ns-eu-cloud.k8gb.io

And the record was successfully created

gcloud dns record-sets list --zone="k8gb" --type=NS --name "cloud.k8gb.io."
NAME            TYPE  TTL  DATA
cloud.k8gb.io.  NS    5    gslb-ns-eu-cloud.k8gb.io.,gslb-ns-us-cloud.k8gb.io.

Checklist

• Unit tests updated
• End user documentation updated

[k8s-ci-robot]

Hi @abaguas. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mloiseleur]

Would you please add a test for this change ?

[abaguas]

Would you please add a test for this change ?

Ups. Done @mloiseleur

[mloiseleur]

/ok-to-test

[mloiseleur]

/lgtm

[mloiseleur]

/retitle fix(Google DNS): ensure trailing dot on NS records

[Raffo]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Raffo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment