Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws.md for guidance on latest EKS Auto Mode #5074

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PranavSathy
Copy link

@PranavSathy PranavSathy commented Feb 9, 2025

AWS EKS Auto Mode recommends an authentication mode of API only, which does not leverage the older RBAC config map that this document was referencing.

This adds a note for any users coming to this page (with the relevant error that is thrown for SEO) so that users have guidance on EKS Auto Mode.

Description

Simply updating the documentation to provide a warning and guidance for users on EKS Auto-Mode on how to modify the trust.json example for IRSA based authentication (production recommended approach) to work with API authentication mode (recommended on AWS EKS Auto Mode).

Checklist

  • Unit tests updated
  • End user documentation updated

AWS EKS Auto Mode recommends an authentication mode of `API` only, which does not leverage the older RBAC config map that this document was referencing. 

This adds a note for any users coming to this page (with the relevant error that is thrown for SEO) so that users have guidance on EKS Auto Mode.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign szuecs for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

CLA Not Signed

@k8s-ci-robot
Copy link
Contributor

Welcome @PranavSathy!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @PranavSathy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 9, 2025
@mloiseleur
Copy link
Contributor

@PranavSathy You need to sign the CLA before we can review this PR

@ivankatliarchuk
Copy link
Contributor

Could you share a link to an issue or docs? I have not came across this requirement or an issue yet on AWS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants