Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias fix #220

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Alias fix #220

merged 3 commits into from
Jan 23, 2025

Conversation

kfswain
Copy link
Collaborator

@kfswain kfswain commented Jan 23, 2025

had a little formatting whoopsie, fixing

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 23, 2025
@k8s-ci-robot k8s-ci-robot requested a review from ahg-g January 23, 2025 20:34
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Jan 23, 2025
Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 55cda03
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/6792a845355aca0008f8b65f
😎 Deploy Preview https://deploy-preview-220--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 23, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jan 23, 2025
@robscott
Copy link
Member

Thanks @kfswain!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2025
@k8s-ci-robot k8s-ci-robot merged commit 980bec7 into kubernetes-sigs:main Jan 23, 2025
8 checks passed
@kfswain kfswain deleted the alias-fix branch January 23, 2025 20:50
LukeAVanDrie pushed a commit to LukeAVanDrie/gateway-api-inference-extension that referenced this pull request Jan 24, 2025
* formatting aliases

* removing non-alias approvers

* username fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants