Consistent validation for reference types #430
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: robscott The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
size/L
| // | ||
| // +kubebuilder:validation:MaxLength=253 | ||
| // +kubebuilder:validation:Pattern=`^$|^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$` | ||
| type Group string |
There was a problem hiding this comment.
For the record, all of these types are directly copied from Gateway API. I think we've made an intentional decision to avoid adding a dependency on Gateway API, so copying types seems like a reasonable alternative here. Just wanted to mention that this was some intentional duplication.
There was a problem hiding this comment.
Can we pls move here the LabelValue/Key from https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/main/api/v1alpha2/inferencepool_types.go#L150 as well?
Although we had most of this validation for the PoolObjectRef, we did not for the ExtensionRef. We also renamed the go field name from TargetPortNumber to PortNumber, but missed the corresponding json tag, this also fixes that.