create pods during integration tests #431
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Kuromesi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @Kuromesi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/M
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Kuromesi <[email protected]>
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
There was a problem hiding this comment.
Ideally we create a namespace for each test and clean it all up. To do this, we need a few things:
- Create pool/model objects just like we do for Pods, not read them from files
- We to start the controllers as part of setUpHermeticServer, not BeforeSuite. It would be great if BeforeSuite only starts the api-server (i.e., cfg, err := testEnv.Start()).
We can do this as a follow up.
| if err := serverRunner.AsRunnable(logger.WithName("ext-proc")).Start(serverCtx); err != nil { | ||
| logutil.Fatal(logger, err, "Failed to start ext-proc server") | ||
| } | ||
| }() | ||
|
|
||
| // sleep 5 seconds to wait for datastore to be synced | ||
| time.Sleep(5 * time.Second) |
There was a problem hiding this comment.
I suggest we avoid setting random sleeps like this, and use something like Eventually: https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/main/test/integration/hermetic_test.go#L522.
This will be alot easier if we migrate to use ginkgo!
resolve #357