-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies for K8s 1.22+ #133
Conversation
The current version of cert-controller won't work on K8s 1.22+ since it uses the removed v1beta CRD API. This change picks up the latest cert-controller and all the other key latest dependencies. Key updates: * controller-runtime to v0.11 * cert-controller to the latest to pick up CRD v1beta removal * K8s client libs to 1.23 * controller-tools to latest * Various other small changes Tested: smoke tests
@adrianludwin: GitHub didn't allow me to request PR reviews from the following users: erikgb. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
FYI: We have experienced issues upgrading our controllers to controller-runtime 0.11.0 and K8s 1.23. See kubernetes-sigs/controller-runtime#1786. Might not be an issue here, but we decided to revert the upgrade - at least for now. |
/lgtm |
@erikgb: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
The current version of cert-controller won't work on K8s 1.22+ since it
uses the removed v1beta CRD API. This change picks up the latest
cert-controller and all the other key latest dependencies.
Key updates:
Tested: smoke tests