Disable kube-rbac-proxy by default

[vishh]

HNC does not expose PII information via /metrics endpoint. Disabling employing kube-rbac-proxy by default.

Tested: make test-smoke passes.

[k8s-ci-robot]

Welcome @vishh!

It looks like this is your first PR to kubernetes-sigs/hierarchical-namespaces 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/hierarchical-namespaces has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @vishh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[adrianludwin]

/ok-to-test
/cc @rjbez17

Hey Ryan, the kube-rbac-proxy has been causing us some trouble, e.g. staying on top of the latest version internally at Google for Hierarchy Controller, and also figuring out which multiarch version to use for #45. @vishh (who's a Googler starting to work on HNC) reviewed the metrics and we don't think there's any reason to protect them with the RBAC proxy as it's all pretty innocuous. wdyt?

@vishh, did you deploy this to one of your own clusters and run any e2e tests (e.g. make test-smoke)? If so, can you please add a "Tested:" comment to your commit (example)? Note that the Prow presubmits don't run e2e tests, only the postsubmits.

[vishh]

I can run e2e tests, but I felt a kustomize build was sufficient for this change.

…

On Thu, Jun 24, 2021 at 12:34 PM Adrian Ludwin ***@***.***> wrote: /ok-to-test /cc @rjbez17 <https://github.com/rjbez17> Hey Ryan, the kube-rbac-proxy has been causing us some trouble, e.g. staying on top of the latest version internally at Google for Hierarchy Controller, and also figuring out which multiarch version to use for #45 <#45>. @vishh <https://github.com/vishh> (who's a Googler starting to work on HNC) reviewed the metrics and we don't think there's any reason to protect them with the RBAC proxy as it's all pretty innocuous. wdyt? @vishh <https://github.com/vishh>, did you deploy this to one of your own clusters and run any e2e tests (e.g. make test-smoke)? If so, can you please add a "Tested:" comment to your commit (example <89b6f66>)? Note that the Prow presubmits don't run e2e tests, only the postsubmits. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#50 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABV4QKCMFZNFNSID6PEUTF3TUOCE3ANCNFSM47IQAJVQ> .

[vishh]

@adrianludwin ran smoke tests and they passed against my GKE cluster.

[adrianludwin]

Cool, thanks.
/lgtm
/approve
/hold
/cc @rjbez17

Ryan, lgty?

[rjbez17]

/lgtm
/approve
/hold cancel

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianludwin, rjbez17, vishh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adrianludwin,rjbez17]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment