Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Go 1.17 #85

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Conversation

adrianludwin
Copy link
Contributor

Tested: unit tests; partial smoke test (my workstation is seeing random
timeouts).

Tested: unit tests; partial smoke test (my workstation is seeing random
timeouts).
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 27, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 27, 2021
@adrianludwin
Copy link
Contributor Author

I expect this to be blocked by kubernetes/test-infra#23756 due to the change in go fmt from 1.16 to 1.17.

@adrianludwin
Copy link
Contributor Author

As expected, this fails when built by Go 1.16.

@adrianludwin
Copy link
Contributor Author

/retest

@adrianludwin
Copy link
Contributor Author

/assign @rjbez17

@rjbez17
Copy link
Contributor

rjbez17 commented Sep 27, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianludwin, rjbez17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adrianludwin,rjbez17]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1ef9e8c into kubernetes-sigs:master Sep 27, 2021
@adrianludwin adrianludwin added this to the release-v0.9 milestone Oct 13, 2021
@adrianludwin adrianludwin deleted the go17 branch March 24, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants