Simpler migration without external dependency #511
Conversation
Git-clone means an external dependency which is hard to test. This ensures that the migration can be done locally without calling a remote repository. Thus, the migration can also be tested.
k8s-ci-robot
added
cncf-cla: yes
Codecov Report
@@ Coverage Diff @@
## master #511 +/- ##
==========================================
+ Coverage 57.42% 58.87% +1.44%
==========================================
Files 23 23
Lines 996 997 +1
==========================================
+ Hits 572 587 +15
+ Misses 368 350 -18
- Partials 56 60 +4
Continue to review full report at Codecov.
|
| @@ -48,15 +44,22 @@ func Migrate(paths environment.Paths) error { | |||
| klog.V(2).Infoln("Already migrated") | |||
| return nil | |||
| } | |||
| indexPath := paths.IndexPath() | |||
| tmpPath := filepath.Join(paths.BasePath(), "tmp_index_migration") | |||
There was a problem hiding this comment.
this wouldn't be better as os.TempDir?
There was a problem hiding this comment.
TempDir would be safer of course, but I wanted to avoid moving across file systems.
|
/lgtm |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, corneliusweig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
This migrates the krew home to the new layout without an external dependency.
Related issue: #505
Also see #505 (comment)
cc @chriskim06