Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calico v3.28.[0-1] checksums and change calico default version #11234

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Calico v3.28.[0-1] checksums and change calico default version #11234

merged 3 commits into from
Aug 29, 2024

Conversation

ehsan310
Copy link
Contributor

@ehsan310 ehsan310 commented May 25, 2024 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Calico v3.28.1 checksum and change calico default to 3.27.3

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Calico v3.28.0 and v3.28.1 checksum and change calico default version
Update calico apiserver deployment to use new readiness probe

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels May 25, 2024
@k8s-ci-robot k8s-ci-robot requested review from ErikJiang and mzaian May 25, 2024 17:39
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 25, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @ehsan310. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yankay
Copy link
Member

yankay commented May 27, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 27, 2024
@ehsan310 ehsan310 changed the title Calico v2.28.0 checksum and change calico default version Calico v3.28.0 checksum and change calico default version May 27, 2024
@ehsan310
Copy link
Contributor Author

I noticed calico api server health probe is changed, I'll update that as well.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 31, 2024
mzaian
mzaian approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2024
@ehsan310
Copy link
Contributor Author

ehsan310 commented Jun 3, 2024

@mzaian with this health probe changes do we have to put minimum version for calico ? how do we usually do minimum version ?

@mzaian
Copy link
Contributor

mzaian commented Jun 3, 2024

@mzaian with this health probe changes do we have to put minimum version for calico ? how do we usually do minimum version ?

There is no minimum version settings in kubespray. The calico api server is disabled by default see: https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubespray-defaults/defaults/main/download.yml#L112
If you would like to support previous version(s) you can do an if condition for the readinessProbe configuration.

@ehsan310
Copy link
Contributor Author

ehsan310 commented Jun 3, 2024

@mzaian it is now conditional on 3.28 version

@ehsan310
Copy link
Contributor Author

ehsan310 commented Jun 5, 2024

/retest-failed

@ehsan310
Copy link
Contributor Author

ehsan310 commented Jun 5, 2024

@mzaian something wrong with tests ?

@ehsan310
Copy link
Contributor Author

ehsan310 commented Jun 8, 2024

/retest-failed

@ant31
Copy link
Contributor

ant31 commented Jun 26, 2024

/retest

1 similar comment
@ehsan310
Copy link
Contributor Author

ehsan310 commented Aug 1, 2024

/retest

@ehsan310
Copy link
Contributor Author

ehsan310 commented Aug 1, 2024

@ant31 @mzaian
New Calico version is release and I am going to raise another PR for 3.28.1 but tests are failing here.

I am not sure if there is anything I can do to fix them ?

@mzaian mzaian closed this Aug 1, 2024
@mzaian mzaian reopened this Aug 1, 2024
@mzaian
Copy link
Contributor

mzaian commented Aug 1, 2024

I closed/reopened for the tests. Also FYI: https://github.com/projectcalico/calico/releases/tag/v3.28.1 and I would recommend not setting the default to an earlier release and wait for 1 or 2 more versions.

/cc @yankay @ErikJiang

@k8s-ci-robot k8s-ci-robot requested a review from yankay August 1, 2024 17:25
@yankay
Copy link
Member

yankay commented Aug 28, 2024

HI @cyclinder

Would you please help to review it.

@yankay yankay requested a review from cyclinder August 28, 2024 05:50
cyclinder
cyclinder reviewed Aug 28, 2024
View reviewed changes
Copy link
Contributor

@cyclinder cyclinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ehsan310 Thanks for the update! It looks good, to better keep constant with the calico upstrem, Can you update the volume type of the calico-node.yaml? see projectcalico/calico@ea7b0b6

@M-JavadHeydarpour
Copy link
Contributor

Hi, I encountered another issue while using Calico v3.27.3. Due to this problem, we also need to consider upgrading to Calico v3.28.1.

Additional Information

For more details, please refer to the related issue: kubernetes-sigs/kubespray#11475.

@mzaian
Copy link
Contributor

mzaian commented Aug 28, 2024

Hi, I encountered another issue while using Calico v3.27.3. Due to this problem, we also need to consider upgrading to Calico v3.28.1.

Additional Information

For more details, please refer to the related issue: kubernetes-sigs/kubespray#11475.

Hello @M-JavadHeydarpour
Is this issue fixed in 3.28.X ?? Did you test it?

@mzaian
Copy link
Contributor

mzaian commented Aug 28, 2024 •
edited
Loading

Hi, I encountered another issue while using Calico v3.27.3. Due to this problem, we also need to consider upgrading to Calico v3.28.1.

Additional Information

For more details, please refer to the related issue: kubernetes-sigs/kubespray#11475.

Hello @M-JavadHeydarpour Is this issue fixed in 3.28.X ?? Did you test it?

Fixed in v3.28.1 amd v3.27.4 as I checked. I create a PR for release-2.25 #11476

@mzaian
Copy link
Contributor

mzaian commented Aug 28, 2024

/retitle Calico v3.28.[0-1] checksums and change calico default version

@k8s-ci-robot k8s-ci-robot changed the title Calico v3.28.0 checksum and change calico default version Calico v3.28.[0-1] checksums and change calico default version Aug 28, 2024
@mzaian
Copy link
Contributor

mzaian commented Aug 28, 2024

/hold
@ehsan310 Please Make v3.28.1 default and reflect that in the readme.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2024
@mzaian mzaian mentioned this pull request Aug 28, 2024
Closed
@ehsan310
Copy link
Contributor Author

/hold @ehsan310 Please Make v3.28.1 default and reflect that in the readme.

Done

mzaian
mzaian approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehsan310, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2024
@ehsan310
Copy link
Contributor Author

Hi @ehsan310 Thanks for the update! It looks good, to better keep constant with the calico upstrem, Can you update the volume type of the calico-node.yaml? see projectcalico/calico@ea7b0b6

@cyclinder this is done as well.

@mzaian PR is on hold can't be merged.

@mzaian
Copy link
Contributor

mzaian commented Aug 29, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2024
@ehsan310
Copy link
Contributor Author

@mzaian just rebased with master , sounds like it needs another approval :)

@ehsan310
Copy link
Contributor Author

the failed test in not relevant to my changes.

@mzaian
Copy link
Contributor

mzaian commented Aug 29, 2024

the failed test in not relevant to my changes.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 924a979 into kubernetes-sigs:master Aug 29, 2024
39 checks passed
kpoxo6op pushed a commit to kpoxo6op/kubespray that referenced this pull request Dec 27, 2024
@ehsan310 @kpoxo6op
Calico v3.28.[0-1] checksums and change calico default version (kuber…
9df8194 
…netes-sigs#11234)

* make calico api server manifest backward compatible with version older than 3.27.3

Add 3.28.1 checksums
Add 3.28.0 checksums
Change default version to 3.27.3

* change default calico version to 3.28.1

* Set mount type to DirectoryOrCreate for hostPath needed by Calico
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyclinder cyclinder cyclinder left review comments

@mzaian mzaian mzaian approved these changes

@ErikJiang ErikJiang Awaiting requested review from ErikJiang

@yankay yankay Awaiting requested review from yankay

Assignees

@mzaian mzaian

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ehsan310 @k8s-ci-robot @yankay @mzaian @ant31 @M-JavadHeydarpour @cyclinder