-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tico88612 as reviewer #11453
Add tico88612 as reviewer #11453
Conversation
Signed-off-by: ChengHao Yang <[email protected]>
/ok-to-test |
/cherry-pick release-2.24 |
@tico88612: once the present PR merges, I will cherry-pick it on top of release-2.24 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrFreezeex, tico88612, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tico88612: #11453 failed to apply on top of branch "release-2.24":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@tico88612: new pull request created: #11454 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: ChengHao Yang <[email protected]>
What type of PR is this?
/kind flake
What this PR does / why we need it:
I am glad to be one of the reviewers of Kubespray. (I'm still in the LFX internship program, but I've already tried to review some of the PRs.)
Does this PR introduce a user-facing change?: