Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.24] Update to last patch versions (crio, kubernetes, containerd, runc, nerdctl, etcd) #11516

Merged
merged 6 commits into from
Sep 12, 2024

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented Sep 9, 2024

What type of PR is this?
/kind api-change

What this PR does / why we need it:
Add the latest patch version on some core components

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Default to kubernetes v1.28.14
Default to etcd v3.5.16
Default to containerd v1.7.22
Default to cri-o v1.28.10
Default to nerdctl 1.7.7
Default to runc  v1.1.14

/label tide-merge-method-merge
/cc @mzaian

@k8s-ci-robot k8s-ci-robot requested a review from mzaian September 9, 2024 09:07
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Sep 9, 2024
@k8s-ci-robot
Copy link
Contributor

@VannTen: The label(s) /label tide-merge-method-merge cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

What type of PR is this?
/kind api-change

What this PR does / why we need it:
Add the latest patch version on some core components

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Default to kubernetes v1.28.13.
Default to etcd v3.5.15
Default to containerd v1.7.21
Default to cri-o v1.28.10
Default to nerdctl 1.7.6
Default to runc  v1.1.14

/label tide-merge-method-merge
/cc @mzaian

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 9, 2024
@VannTen
Copy link
Contributor Author

VannTen commented Sep 9, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 9, 2024
@VannTen
Copy link
Contributor Author

VannTen commented Sep 9, 2024

/label tide/merge-method-merge

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges. label Sep 9, 2024
@yankay yankay closed this Sep 11, 2024
@yankay yankay reopened this Sep 11, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 11, 2024
@VannTen
Copy link
Contributor Author

VannTen commented Sep 11, 2024

@yankay @ant31 I somewhat backported the CI change, do we want to put that in a separate PR to release-2.24 or just go with this one ? IMO using the merge method give us enough leeway to revert stuff as needed, wdyt ?

@yankay
Copy link
Member

yankay commented Sep 12, 2024

Thanks @VannTen
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2024
@mzaian
Copy link
Contributor

mzaian commented Sep 12, 2024

@VannTen New versions are out just today "v1.28.14, v1.29.9 and 1.30.5" maybe you could also add them If you like.

@VannTen
Copy link
Contributor Author

VannTen commented Sep 12, 2024 via email

- crio
- kubelet
- kubectl
- kubeadm
- etcd
- calicoctl
- ciliumcli
- runc
- nerdctl
- containerd
- yq
VannTen and others added 5 commits September 12, 2024 09:37
- runc
- containerd
- nerdctl
- etcd
- crio
- kubelet, kubectl, kubeadm
We'll sort it out once we have fixed master
@VannTen
Copy link
Contributor Author

VannTen commented Sep 12, 2024

@VannTen New versions are out just today "v1.28.14, v1.29.9 and 1.30.5" maybe you could also add them If you like.

We really ought to have a bot do that for us 😆

@VannTen
Copy link
Contributor Author

VannTen commented Sep 12, 2024

/cc @mzaian
(Added the last patches version)

@VannTen VannTen requested review from yankay September 12, 2024 14:10
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VannTen You Rock!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mzaian, VannTen, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 80201c5 into kubernetes-sigs:release-2.24 Sep 12, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants