Partial Cilium 1.16+ Support & Add vars for configuring cilium IP load balancer pools and bgp v1 & v2 apis #11620

logicsys · 2024-10-09T18:28:19Z

What type of PR is this?

/kind feature

What this PR does / why we need it:
Allows user to define Cilium IP Load Balancer pools & BGP Peer Policies, the following new defaults have been added to preserve current behavior:

# -- Configure Loadbalancer IP Pools
cilium_loadbalancer_ip_pools: []

# -- Enable BGP Control Plane
cilium_enable_bgp_control_plane: false

# -- Configure BGP Instances (New bgpv2 API v1.16+)
cilium_bgp_cluster_configs: []

# -- Configure BGP Peers (New bgpv2 API v1.16+)
cilium_bgp_peer_configs: []

# -- Configure BGP Advertisements (New bgpv2 API v1.16+)
cilium_bgp_advertisements: []

# -- Configure BGP Node Config Overrides (New bgpv2 API v1.16+)
cilium_bgp_node_config_overrides: []

# -- Configure BGP Peers (Legacy < v1.16)
cilium_bgp_peering_policies: []

Due to CRDs being necessary before these features can be configured, this change first waits for these CRDs to exist before attempting to create, if above vars are configured.

Does this PR introduce a user-facing change?:
No user-facing change, current behavior is preserved with defaults.

Partial Support of Cilium v1.16+ - kube-proxy replacement var changes
Add optional support for configuring _BGP Control Plane_, _IP Load Balancer Pools_ , _Legacy BGP Peer Config v1_  and _BGP Config v2_ features in Cilium

linux-foundation-easycla · 2024-10-09T18:28:22Z

The committers listed above are authorized under a signed CLA.

✅ login: logicsys (f73b7d1, 11718da)

k8s-ci-robot · 2024-10-09T18:28:27Z

Welcome @logicsys!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2024-10-09T18:28:28Z

Hi @logicsys. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

logicsys · 2024-10-09T18:38:57Z

/kind feature

VannTen · 2024-10-10T07:04:56Z

/ok-to-test

logicsys · 2024-10-17T14:36:14Z

sorry was one last typo to fix there, ready for review again now

roles/network_plugin/cilium/templates/cilium/ds.yml.j2

tico88612

Some suggestions.

roles/network_plugin/cilium/tasks/apply.yml

yankay · 2024-11-07T01:38:31Z

HI @cyclinder
Would you please help to review it?

cyclinder

Hi @logicsys, Thanks for the contribution. It looks good, just a few nits.

cyclinder · 2024-11-07T06:02:05Z

roles/network_plugin/cilium/templates/cilium/cbgpa.yml.j2

@@ -0,0 +1,12 @@
+{% for cbgpadvert in cilium_bgp_advertisements %}
+---


Can the names of these files not be abbreviated? Just for readability.

yeah sure, updated there

It seems that the file duplicates with cilium-bgp-advertisement.yml.j2, Do we need to remove this?

Ah sorry looks like a bad merge and or squash, will sort now and remove the old templates

sorted there, tested again on my side without issue

thanks, looks good now

/lgtm

/cc @yankay please for the approval

cyclinder · 2024-11-07T06:06:18Z

docs/CNI/cilium.md

+              - {key: somekey, operator: NotIn, values: ['never-used-value']}
+```
+
+For further information, check [BGP Peering Policy documentation](https://docs.cilium.io/en/latest/network/bgp-control-plane/bgp-control-plane-v1/#bgp-peering-policy-legacy)


Do we also need to mention the CiliumBGPNodeConfigOverride resources? see https://docs.cilium.io/en/stable/network/bgp-control-plane/bgp-control-plane-v2/#bgp-configuration-override

may as well, I've added that in there too, tested on my side without issue, just the CI test run to finish now

…olicies

…ndle cilium_kube_proxy_replacement unsupported values

k8s-ci-robot · 2024-11-11T06:51:09Z

@cyclinder: GitHub didn't allow me to request PR reviews from the following users: the, approval, please, for.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @yankay please for the approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

yankay · 2024-11-19T02:44:38Z

Thanks @logicsys
/approve

k8s-ci-robot · 2024-11-19T02:44:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logicsys, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [yankay]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…d balancer pools and bgp v1 & v2 apis (kubernetes-sigs#11620) * Add vars for configuring cilium IP load balancer pools and bgp peer policies * Cilium 1.16+ Support - Add vars for configuring cilium bgpv2 api & handle cilium_kube_proxy_replacement unsupported values

k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Oct 9, 2024

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 9, 2024

k8s-ci-robot requested review from mzaian and tico88612 October 9, 2024 18:28

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 9, 2024

logicsys changed the title ~~Add vars for configuring cilium IP load balancer pools and bgp peer p…~~ WIP Add vars for configuring cilium IP load balancer pools and bgp peer p… Oct 9, 2024

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 9, 2024

logicsys changed the title ~~WIP Add vars for configuring cilium IP load balancer pools and bgp peer p…~~ WIP Add vars for configuring cilium IP load balancer pools and bgp peer policies Oct 9, 2024

k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 9, 2024

logicsys force-pushed the lsys-temp-rebase branch 4 times, most recently from b3b2637 to db358fb Compare October 9, 2024 19:02

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 9, 2024

logicsys force-pushed the lsys-temp-rebase branch from db358fb to 1945183 Compare October 9, 2024 19:13

logicsys changed the title ~~WIP Add vars for configuring cilium IP load balancer pools and bgp peer policies~~ Add vars for configuring cilium IP load balancer pools and bgp peer policies Oct 9, 2024

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2024

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 10, 2024

logicsys force-pushed the lsys-temp-rebase branch 2 times, most recently from 1183307 to 1dd8bda Compare October 10, 2024 16:02

logicsys force-pushed the lsys-temp-rebase branch from 7a2237c to 71ded12 Compare October 17, 2024 14:35

logicsys requested a review from tico88612 October 18, 2024 08:45

logicsys force-pushed the lsys-temp-rebase branch from 71ded12 to 37b0750 Compare October 21, 2024 00:21

tico88612 reviewed Oct 21, 2024

View reviewed changes

roles/network_plugin/cilium/templates/cilium/ds.yml.j2 Outdated Show resolved Hide resolved

logicsys force-pushed the lsys-temp-rebase branch from 37b0750 to 438a951 Compare October 21, 2024 23:10

logicsys requested a review from tico88612 October 23, 2024 00:30

tico88612 reviewed Oct 25, 2024

View reviewed changes

logicsys force-pushed the lsys-temp-rebase branch from 438a951 to 8eafe7e Compare October 26, 2024 18:23

logicsys requested a review from tico88612 October 26, 2024 18:53

cyclinder reviewed Nov 7, 2024

View reviewed changes

Add vars for configuring cilium IP load balancer pools and bgp peer p…

11718da

…olicies

logicsys force-pushed the lsys-temp-rebase branch from 8eafe7e to 2cf8b8b Compare November 9, 2024 22:42

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 9, 2024

logicsys requested a review from cyclinder November 9, 2024 23:11

Cilium 1.16+ Support - Add vars for configuring cilium bgpv2 api & ha…

f73b7d1

…ndle cilium_kube_proxy_replacement unsupported values

logicsys force-pushed the lsys-temp-rebase branch from 2cf8b8b to f73b7d1 Compare November 11, 2024 03:08

k8s-ci-robot assigned cyclinder Nov 11, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2024

k8s-ci-robot requested a review from yankay November 11, 2024 06:51

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2024

k8s-ci-robot merged commit b854196 into kubernetes-sigs:master Nov 19, 2024
40 checks passed

tico88612 mentioned this pull request Nov 27, 2024

Release Proposal v2.27 #11752

Closed

ledroide mentioned this pull request Jan 2, 2025

Cilium deprecated values for kube-proxy-replacement now refused by daemonset/cilium #11417

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Partial Cilium 1.16+ Support & Add vars for configuring cilium IP load balancer pools and bgp v1 & v2 apis #11620

Partial Cilium 1.16+ Support & Add vars for configuring cilium IP load balancer pools and bgp v1 & v2 apis #11620

logicsys commented Oct 9, 2024 •

edited

Loading

linux-foundation-easycla bot commented Oct 9, 2024 •

edited

Loading

k8s-ci-robot commented Oct 9, 2024

k8s-ci-robot commented Oct 9, 2024

logicsys commented Oct 9, 2024

VannTen commented Oct 10, 2024

logicsys commented Oct 17, 2024 •

edited

Loading

tico88612 left a comment

yankay commented Nov 7, 2024

cyclinder left a comment

cyclinder Nov 7, 2024

logicsys Nov 9, 2024

cyclinder Nov 11, 2024

logicsys Nov 11, 2024

logicsys Nov 11, 2024

cyclinder Nov 11, 2024

cyclinder Nov 11, 2024

cyclinder Nov 7, 2024

logicsys Nov 9, 2024

cyclinder Nov 11, 2024

k8s-ci-robot commented Nov 11, 2024

yankay commented Nov 19, 2024

k8s-ci-robot commented Nov 19, 2024

		@@ -0,0 +1,12 @@
		{% for cbgpadvert in cilium_bgp_advertisements %}
		---

Partial Cilium 1.16+ Support & Add vars for configuring cilium IP load balancer pools and bgp v1 & v2 apis #11620

Partial Cilium 1.16+ Support & Add vars for configuring cilium IP load balancer pools and bgp v1 & v2 apis #11620

Conversation

logicsys commented Oct 9, 2024 • edited Loading

linux-foundation-easycla bot commented Oct 9, 2024 • edited Loading

k8s-ci-robot commented Oct 9, 2024

k8s-ci-robot commented Oct 9, 2024

logicsys commented Oct 9, 2024

VannTen commented Oct 10, 2024

logicsys commented Oct 17, 2024 • edited Loading

tico88612 left a comment

Choose a reason for hiding this comment

yankay commented Nov 7, 2024

cyclinder left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k8s-ci-robot commented Nov 11, 2024

yankay commented Nov 19, 2024

k8s-ci-robot commented Nov 19, 2024

logicsys commented Oct 9, 2024 •

edited

Loading

linux-foundation-easycla bot commented Oct 9, 2024 •

edited

Loading

logicsys commented Oct 17, 2024 •

edited

Loading