Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of community.general #11724

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented Nov 18, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:
We use the persistent option of modprobe, which was introduced in 7.0.0

Special notes for your reviewer:
See ansible-collections/community.general#9144

Does this PR introduce a user-facing change?:

Use correct version for community.general collection

We use the persistent option of modprobe, which was introduced in 7.0.0
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 18, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 18, 2024
@VannTen
Copy link
Contributor Author

VannTen commented Nov 18, 2024

/ok-to-test
/cherrypick release-2.24
/cherrypick release-2.25
/cherrypick release-2.26

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 18, 2024
@k8s-infra-cherrypick-robot

@VannTen: once the present PR merges, I will cherry-pick it on top of release-2.24, release-2.25, release-2.26 in new PRs and assign them to you.

In response to this:

/ok-to-test
/cherrypick release-2.24
/cherrypick release-2.25
/cherrypick release-2.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6536ed4 into kubernetes-sigs:master Nov 18, 2024
41 checks passed
@k8s-infra-cherrypick-robot

@VannTen: #11724 failed to apply on top of branch "release-2.24":

Applying: Bump version of community.general
Using index info to reconstruct a base tree...
M	galaxy.yml
Falling back to patching base and 3-way merge...
Auto-merging galaxy.yml
CONFLICT (content): Merge conflict in galaxy.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Bump version of community.general

In response to this:

/ok-to-test
/cherrypick release-2.24
/cherrypick release-2.25
/cherrypick release-2.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@VannTen: #11724 failed to apply on top of branch "release-2.25":

Applying: Bump version of community.general
Using index info to reconstruct a base tree...
M	galaxy.yml
Falling back to patching base and 3-way merge...
Auto-merging galaxy.yml
CONFLICT (content): Merge conflict in galaxy.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Bump version of community.general

In response to this:

/ok-to-test
/cherrypick release-2.24
/cherrypick release-2.25
/cherrypick release-2.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@VannTen: new pull request created: #11726

In response to this:

/ok-to-test
/cherrypick release-2.24
/cherrypick release-2.25
/cherrypick release-2.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@VannTen
Copy link
Contributor Author

VannTen commented Nov 18, 2024 via email

kpoxo6op pushed a commit to kpoxo6op/kubespray that referenced this pull request Dec 27, 2024
We use the persistent option of modprobe, which was introduced in 7.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants