Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize kubelet root directory (/var/lib/kubelet) #11988

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ant31
Copy link
Contributor

@ant31 ant31 commented Feb 22, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

In some situation, users wants to use a different directory than the default "/var/lib/kubelet'.
It was previously possible by setting the kubelet_custom_flags but many roles were still hardcoded to "/var/lib/kubelet".

Which issue(s) this PR fixes:

Fixes #7087

Special notes for your reviewer:

Not sure the best way to handle users that were using the kubelet_custom_flags.

Does this PR introduce a user-facing change?:

Add new variable: `kubelet_root_dir`  to change the kubelet root default "/var/lib/kubelet" to a custom directory

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 22, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ant31

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 22, 2025
@ant31
Copy link
Contributor Author

ant31 commented Feb 25, 2025

/retest

@ant31
Copy link
Contributor Author

ant31 commented Feb 26, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 26, 2025
@ant31 ant31 closed this Feb 26, 2025
@ant31 ant31 reopened this Feb 26, 2025
@ant31 ant31 added the ci-full Run every available tests label Feb 26, 2025
@ant31 ant31 closed this Feb 26, 2025
@ant31 ant31 reopened this Feb 26, 2025
@ant31
Copy link
Contributor Author

ant31 commented Feb 26, 2025

/hold

It's not so easy to change the default. Too many operator, csi and other software in the ecosystem have hardcoded /var/lib/kubelet.
One way to deal with this is to mount bind the new root to /var/lib/kubelet.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. ci-full Run every available tests cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to config kubelet path?
2 participants