Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop rkt support as it's not maintained #4671

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Drop rkt support as it's not maintained #4671

merged 1 commit into from
Apr 29, 2019

Conversation

woopstar
Copy link
Member

What type of PR is this?
/kind cleanup
/kind design
/kind documentation

What this PR does / why we need it:
Will remove rkt support in Kubespray

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/design Categorizes issue or PR as related to design. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 29, 2019
@k8s-ci-robot k8s-ci-robot requested review from Miouge1 and mirwan April 29, 2019 06:14
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 29, 2019
@woopstar
Copy link
Member Author

ci check this

@woopstar woopstar added this to the 2.10 milestone Apr 29, 2019
@mattymo
Copy link
Contributor

mattymo commented Apr 29, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattymo, woopstar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 38af93b into kubernetes-sigs:master Apr 29, 2019
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request May 5, 2019
@woopstar @LuckySB
Remove rkt support (kubernetes-sigs#4671)
de5194c
unbreakab1e pushed a commit to joomcode/kubespray that referenced this pull request Jun 5, 2019
@woopstar @unbreakab1e
Remove rkt support (kubernetes-sigs#4671)
07c251a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miouge1 Miouge1 Awaiting requested review from Miouge1

@mirwan mirwan Awaiting requested review from mirwan

Assignees

@mattymo mattymo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/design Categorizes issue or PR as related to design. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
2.10
Development

Successfully merging this pull request may close these issues.
3 participants
@woopstar @mattymo @k8s-ci-robot