-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ppc64le support #8505
Added ppc64le support #8505
Conversation
|
Welcome @mgiessing! |
Hi @mgiessing. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Nice work, thanks for doing this. /ok-to-test |
/release-note-edit Add ppc64le support |
kubernetes/test-infra#23473 ~~nicely not working 🤷 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mgiessing Not sure how many people need this but thanks 🙇
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, mgiessing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@floryut Probably not as many as for x86, but it definately helps 🙌 |
@floryut Just for my understanding (and let me say I'm not very experienced with a "general" releasing process at all): I thought all approved PRs will basically make it into the next release, but that seems not to be the case. I just found out v2.18.1 still supports only i386, x86 & arm which means ppc64le users need to work on the master/main branch and that can sometimes be troublesome. |
@mgiessing You thought right, but 2.18.1 is a minor 2.18 release containing only backport PR from master branch (and mainly bug fixing, sometimes feature) |
Okay got it - thanks for clarification! |
* Added ppc64le support * Fixed linting errors
* Added ppc64le support * Fixed linting errors
* Added ppc64le support * Fixed linting errors
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds support for ppc64le architecture. Therefore the relevant checksums have been added accordingly.
At the moment this does only work with
container_manager
set todocker
as there is no ppc64le release for the default valuecontainerd
. Tested it on RHEL/CentOS.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: