-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added download configuration for cilium hubble images #9376
Added download configuration for cilium hubble images #9376
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @oomichi
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating.
After rechecking this again, I have other questions.
Signed-off-by: bo.jiang <[email protected]>
Thanks for updating. /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ErikJiang Thank you 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ErikJiang, floryut, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: bo.jiang <[email protected]> Signed-off-by: bo.jiang <[email protected]>
Signed-off-by: bo.jiang <[email protected]> Signed-off-by: bo.jiang <[email protected]>
Signed-off-by: bo.jiang <[email protected]> Signed-off-by: bo.jiang <[email protected]>
Signed-off-by: bo.jiang <[email protected]> Signed-off-by: bo.jiang <[email protected]>
Signed-off-by: bo.jiang [email protected]
What type of PR is this?
/kind feature
What this PR does / why we need it:
Added download configuration for cilium hubble images in download role.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: