Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky unit test] TestPreemption/preempt_newer_workloads_with_the_same_priority #4425

Open
mimowo opened this issue Feb 27, 2025 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@mimowo
Copy link
Contributor

mimowo commented Feb 27, 2025

What happened**:

The unit test flaked on unrelated branch https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_kueue/4418/pull-kueue-test-unit-main/1895031429167845376

What you expected to happen:

No failures

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

I tried locally to repro, but couldn't after 3k attempts (both local and the branch), using:

go test ./pkg/scheduler/preemption/ -race -c 
stress ./preemption.test -test.run TestPreemption
{Failed  === RUN   TestPreemption/preempt_newer_workloads_with_the_same_priority
    preemption_test.go:1562: Issued preemptions (-want,+got):
          sets.Set[string](
        - 	{"/wl2:InClusterQueue": {}},
        + 	{"/wl3:InClusterQueue": {}},
          )
--- FAIL: TestPreemption/preempt_newer_workloads_with_the_same_priority (0.09s)
}

Still, it failed once so it may repeat. I suppose the issue might be with rounding to 1s in the LastTransitionTime field. Maybe we just need to make 2s difference.

@mimowo mimowo added the kind/bug Categorizes issue or PR as related to a bug. label Feb 27, 2025
@mimowo
Copy link
Contributor Author

mimowo commented Feb 27, 2025

cc @mbobrovskyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

1 participant