Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: TAS support for cohorts #4418

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Feb 26, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of #3761

Special notes for your reviewer:

WIP because still need to:

  1. implement cq.Fits properly for TAS
  2. add integration tests
  3. support preemption for cohorts and add tests

I'm yet considering if we should split this into smaller PRs.

Does this PR introduce a user-facing change?

TAS: Support cohorts and preemption for TopologyAwareScheduling.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 26, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 26, 2025
Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit dca8687
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67c19d98831d060008388b5a

@mimowo mimowo force-pushed the tas-cohort-preemption branch 2 times, most recently from 4f0f3ab to adfc47e Compare February 27, 2025 06:40
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2025
@mimowo mimowo force-pushed the tas-cohort-preemption branch from adfc47e to 710e370 Compare February 27, 2025 08:33
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2025
@mimowo mimowo force-pushed the tas-cohort-preemption branch from 710e370 to a6a9a7f Compare February 27, 2025 08:40
@mimowo
Copy link
Contributor Author

mimowo commented Feb 27, 2025

/test pull-kueue-test-unit-main
Opened: #4425

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2025
@mimowo mimowo force-pushed the tas-cohort-preemption branch from a6a9a7f to 81d08b1 Compare February 28, 2025 10:04
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2025
@mimowo mimowo force-pushed the tas-cohort-preemption branch from 81d08b1 to 06e19bc Compare February 28, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants