Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stand alone pod annotation check in pod webhook #4109

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BenHinthorne
Copy link

What type of PR is this?

/kind feature

This PR adds a check for a "kueue.x-k8s.io/standalone" annotation on plain pods. If this annotation exists, then these pods will be suspended even if their ownerReference is a known integration to Kueue.

Only a draft for now.

What this PR does / why we need it:

At a high level, this would give users more flexibility to process plain pods with Kueue. Currently, users are blocked from allowing Kueue to process any pods that are owned by a known integration to Kueue.

For example, in Spark Apps, the Driver Pod is the Owner of the Executor pods. This prevents the Executor pods from being processed by Kueue at all, because the pod_webhook sees that they are owned by a resource of "Kind: Pod". With this annotation, users would be able to process these executors as plain pods. See the linked issue for more details.

Which issue(s) this PR fixes:

Fixes # #4106

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add support for pods annotated with `kueue.x-k8s.io/standalone` to be suspended and have a workload created for them regardless of their ownerReference being a known Kueue integration. 

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BenHinthorne
Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 30, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @BenHinthorne. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 30, 2025
Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit c86e39c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/679b88a921581f0008788937
😎 Deploy Preview https://deploy-preview-4109--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants