Add label filter to job resource

[ambersun1234]

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR add a label filter to Job resource kind to prevent Kueue from intercepting unintended resource instance

Which issue(s) this PR fixes:

Fixes #4141

Special notes for your reviewer:

Does this PR introduce a user-facing change?

User need to include `app.kubernetes.io/managed-by: kueue` label in their Job definition in order to let Kueue intercept it

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ambersun1234
Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[linux-foundation-easycla]

• ❌ - login: @ambersun1234 / name: Shawn Hsu . The commit (aaa9348) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

[k8s-ci-robot]

Welcome @ambersun1234!

It looks like this is your first PR to kubernetes-sigs/kueue 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kueue has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @ambersun1234. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name	Link
🔨 Latest commit	aaa9348
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67a36a4ec72f7f0008e36f88
😎 Deploy Preview	https://deploy-preview-4152--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[mszadkow]

Let me try to understand, with this you narrowed down Kueue webhooks application to jobs with app.kubernetes.io/managed-by: kueue label?

[ambersun1234]

Yes, only Job with app.kubernetes.io/managed-by: kueue label will be intercept by Kueue

[mimowo]

/hold
We already have a label to indicate if a workload (represented by k8s Job or other Job CRD) is managed by Kueue: kueue.x-k8s.io/queue-name.

[ambersun1234]

@mimowo

If there's multiple jobs, each job have different queue name associate with it, then the label kueue.x-k8s.io/queue-name can't work properly, you'll need to include all possible "queue names" to objectselector, which in my opinion is not viable

[mimowo]

I think the selectors allow to filter just by label key presence, e.g. kubectl get jobs -l kueue.x-k8s.io/queue-name

EDIT: you may need to use matchExpressions , take a look here:

kueue/apis/config/v1beta1/defaults.go

Lines 168 to 174 in 8541885

	MatchExpressions: []metav1.LabelSelectorRequirement{
	{
	Key: "kubernetes.io/metadata.name",
	Operator: metav1.LabelSelectorOpNotIn,
	Values: matchExpressionsValues,
	},
	},

[tenzen-y]

I do not think that we should introduce such a label selector.
If you want to add arbitrary label selector, you could add those by your kustomize override, IMO