-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-4377: Secured Prometheus metrics endpoints #4404
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kannon92 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/assign @gabesaba |
/unassign As I won't be able to take a look until next week |
/assign @PBundyra |
Sure, on it |
/lgtm |
LGTM label has been added. Git tree hash: 72f730f0bc8f1f6ebf62e4c0c154b538fc6770f0
|
New changes are detected. LGTM label has been removed. |
/retitle KEP-4377: Secured Prometheus metrics endpoints |
If you have time, i'd appreciate your insight best practices for metrics security. |
## Design Details | ||
|
||
### Deployment changes | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you put a sentance or a paragraph on when the external certificates are used (IIUC as discussed in the thread when internalCertManager is disabled), and on the defaults (IIUC: /etc/kueue/certs, and the cert names)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a section called Controller changes below.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
KEP for securing metrics with TLS.
Which issue(s) this PR fixes:
KEP for #4377
Special notes for your reviewer:
Does this PR introduce a user-facing change?