Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: create RemoveFinalizersWithStrictPatch KEP #4416

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mykysha
Copy link
Contributor

@mykysha mykysha commented Feb 26, 2025

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Create a KEP for RemoveFinalizersWithStrictMode feature-gate.

Which issue(s) this PR fixes:

Part of #3899

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. labels Feb 26, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 26, 2025
Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit d477d76
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67c047a5a4711c0008063edc

@mykysha mykysha force-pushed the kep/finalizer-feature-gate branch 2 times, most recently from 5755b75 to 38a08d5 Compare February 26, 2025 15:19
@mbobrovskyi
Copy link
Contributor

mbobrovskyi commented Feb 27, 2025

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 12b4eaae7e74b694d10a9165f9dfe9859f9b3ac5

@mykysha mykysha force-pushed the kep/finalizer-feature-gate branch from 38a08d5 to b270f18 Compare February 27, 2025 08:43
@mykysha mykysha changed the title feat: create RemoveFinalizersWithStrictPatch KEP docs: create RemoveFinalizersWithStrictPatch KEP Feb 27, 2025
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/approve
/hold
@tenzen-y @PBundyra would you like to give it a pass too?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, mykysha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2025
@mykysha mykysha force-pushed the kep/finalizer-feature-gate branch from b270f18 to d477d76 Compare February 27, 2025 11:08
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@tenzen-y
Copy link
Member

LGTM /approve /hold @tenzen-y @PBundyra would you like to give it a pass too?

ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/documentation Categorizes issue or PR as related to documentation. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants